Comments (5)
Hi! Thanks for opening this issue.
I'm having trouble recreating the issue. All of the examples work just fine for me. Could you create a minimal reproduction example?
It might help to know that I recently found out that because of some package resolutions that storybook has, the version of css loader that's actually resolved is v3.x. This leads me to ask the following question: is this a bug that in theory should happen, or is this something you're actually seeing?
Btw, I agree, it's totally expected to think that this addon should break given the info you just gave.
from storybook-addon-next.
Ok, this is more complex than I thought at first. The issue is surfaced in my project by a workaround to #23 that is using "nohoist" on the yarn workspace to keep the node_modules
of storybook-addon-next on the same folder it's used, like so:
Doing this decouples the versions of css-loader
required by other dependencies from the one required by storybook-addon-next ([email protected]
), making the error I reported manifest.
I would still say this is a bug, despite manifesting only in specific circumstances, because storybook-addon-next
is incorrectly reporting it supports css-loader
>= 6.0.0, so if the other dependencies upgraded their css-loader version this package would break in regular scenarios too.
I'm still trying to setup a minimal reproduction scenario based on the one I created for #23, but it's becoming a nightmare because it seems the upstream storybook packages don't bode well with yarn workspaces too :/
from storybook-addon-next.
So turns out css-loader
isn't even needed as a dependency so removing the dependency altogether should work for you right?
See #25
from storybook-addon-next.
@volkyeth I'm pretty much good to go with your solution in #24. I'm just wondering if updating the examples' yarn.lock
files would be a nice sanity check to make sure everything installs properly (I've been bitten by package resolution errors one too many times)
from storybook-addon-next.
🎉 This issue has been resolved in version 1.6.1 🎉
The release is available on:
Your semantic-release bot 📦🚀
from storybook-addon-next.
Related Issues (20)
- Does not work with `@nrwl/react/plugins/storybook` addon HOT 16
- Failed to load preset: /dist/preset.js HOT 3
- Next 12.2 newNextLinkBehavior support HOT 7
- I'm trying to use the addon with storybook and react, but can't build storybook once I installed the addon HOT 7
- Autoprefixer not working HOT 5
- Does not work with next/future/image HOT 3
- already written HOT 1
- Doesn't support AVIF format HOT 3
- Incopatibility with @storybook/builder-vite HOT 1
- Nextjs Image Error message Failed to parse src "static/media/public/logo.jpeg" on `next/image` HOT 3
- next 13 support HOT 11
- Error: NextRouter was not mounted. https://nextjs.org/docs/messages/next-router-not-mounted HOT 4
- Enabling react strict mode with this addon causes "Rendered more hooks than during the previous render." error. HOT 1
- Examples broken on next13, node 16.17.0 HOT 2
- Allow use of ES Module for NextJS config HOT 1
- Support Storybook v7 for upgrading HOT 9
- Nextjs Image Error message Failed to parse src "static/media/public/logo.jpeg" on next/legacy/image on Nextv13 HOT 1
- Image doesn't support the `loader` prop HOT 2
- Object.defineProperty(NextImage, '__esModule', descriptor) is no more needed from [email protected] HOT 4
- Next12.2 future/image support HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from storybook-addon-next.