Code Monkey home page Code Monkey logo

Comments (6)

RyanClementsHax avatar RyanClementsHax commented on July 24, 2024

Thanks for opening the issue!

The pull request above fixes the error although I'm not happy with the solution. I think there is a better one I'm missing. The details are spelled out in the pull request description.

By any chance do you have insight?

from storybook-addon-next.

andykenward avatar andykenward commented on July 24, 2024

By any chance do you have insight?

Sorry, I don't

from storybook-addon-next.

andykenward avatar andykenward commented on July 24, 2024

@RyanClementsHax Thanks for resolving this so quickly!

from storybook-addon-next.

RyanClementsHax avatar RyanClementsHax commented on July 24, 2024

So it turns out that @storybook/builder-webpack4 includes css-loader v3.x in its dependencies. Because of this, the resolved version of css-loader used is v3.x.

Because @storybook/builder-webpack4 is included from installing core storybook packages like @storybook/addon-essentials and @storybook/react, I'll just use the solution mentioned.

@RyanClementsHax Thanks for resolving this so quickly!

No problem!

from storybook-addon-next.

github-actions avatar github-actions commented on July 24, 2024

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

from storybook-addon-next.

andykenward avatar andykenward commented on July 24, 2024

@RyanClementsHax Thanks for more details about the issue. I've had issues on previous storybook setups with different css-loader versions and storybook conflicting. Think I even moved everything relating to storybook into it's own project, just so we didn't have to deal with npm package conflicts in production.

It's also an issue when you use the storybook-preset-scss. Depending on the webpack version you have to install different webpack loaders. But this information isn't highlighted in the main README

webpack 4
https://github.com/storybookjs/storybook/blob/a3433c17a08d0ca8debd14f685ef4a040c77837e/docs/snippets/common/storybook-preset-scss.webpack-4.js.mdx

webpack 5
https://github.com/storybookjs/storybook/blob/a3433c17a08d0ca8debd14f685ef4a040c77837e/docs/snippets/common/storybook-preset-scss.webpack-5.js.mdx

There is also an issue with the wrong version of webpack resolving on a storybook install. Which I think is to do with npm versions and how it resolves dependencies. You can get different outcomes on a new npm install without a package-lock.json file 👎🏻
storybookjs/storybook#15336 (comment)

from storybook-addon-next.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.