ryan953 / flow-annotation-check Goto Github PK

Hey hi,

I tried to use your "-x" option, but it's very confusing for me.
The documentation present an array as default value, but to expect the same behaviour as default i tried may ways to make it works :

flow-annotation-check -x '+(node_modules|build|flow-typed)/**/*.js'
flow-annotation-check -x 'src/assets/js/**/*.js'
flow-annotation-check -x '+(node_modules|build|flow-typed)/**/*.js' -x 'src/assets/js/**/*.js'
flow-annotation-check -x '+(node_modules|build|flow-typed|src/assets/js)/**/*.js'
flow-annotation-check -x '+(node_modules|build|flow-typed)/**/*.js|+(src/assets/js)/**/*.js'

And anytime i tried to manage with this string, the exclude option is fully ignored.

The winner is :

flow-annotation-check -x '+(node_modules|build|flow-typed)/**/*.js' -x 'src/assets/js/**/*.js'

But it was very unexpected.

Hey guys,

Thanks for your module, it's very helpfull.
I wonder fi there is a way to enforce the check of "// @flow strict" on the beginning of each files, and exit with an error on the CLI when it's not the case ?

I'm not sure if the option exists yet, i cannot find.

Bye

Version 2.1.0 of flow-typed just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As flow-typed is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

I should've opened a bug before. But track this in this repo too:
3rd-Eden/find-package-json#5

A case like this should not return @flow for the file:

import React, { Component } from 'react';
// @flow

We should test for statements above the first 10 comment blocks and invalidate those comments that occur later on.

Per: https://github.com/facebook/flow/blob/master/src/parsing/parsing_service_js.ml#L324-L327

It's still looking at the first 10 comments/tokens in the file: https://github.com/facebook/flow/blob/master/src/parsing/parsing_service_js.ml#L172

Hi,

First of all: thanks for this great tool! We use it into our CI to check the presence/absence of the flow header on our code.

In our project it validate ~500 files and print the result on the output. This is a lot of output. When a file is invalid we have to scroll all this output to find witch files is not valid.

We were thinking about an options that only list errored files: --only-show-error, or --summary

What did you think about this?

Currently, @flow strict-local is treated like @flow.