rxswiftcommunity / rxmkmapview Goto Github PK

Is something pending to do a release with Swift 4.2 support?

please update dependency 'RxCocoa' and dependency 'RxSwift' version to 4.4.0

Just a heads up that this method throws with a casting error. Looking into figuring it out!

I am using cocoapods with RxSwift 3.1.0

trying to install latest pod version

pod 'RxMKMapView', '~> 3.0.0'

And getting error

[!] Unable to satisfy the following requirements:

• RxMKMapView (~> 3.0.0) required by Podfile

None of your spec sources contain a spec satisfying the dependency: RxMKMapView (~> 3.0.0).

Please add support for swift package 🙂

RxSwift already released its version to support Swift 5. When will RxMKMapView support Swift 5? We are encountering compatibility issues already related to Swift 5 migration. Thanks!

Stacktrace & log output

RxMKMapView/Sources/MKMapView+Rx.swift:174:14: error: type of expression is ambiguous without more context

xcode 10.1
ios 11.4.1

Only if the system is 11.4.1 on the phone, other systems are good
I don't know what went wrong, I hope the author can tell me how to fix it
thankyou

Using the annotation binding doesn't seem to remove any annotations.

Considering the following example, on each region change a new annotation is added and the previous is left on the map.

        annotationSubscription = mapView.rx.regionDidChangeAnimated
            .map { _ -> [MKAnnotation] in
                let a = MKPointAnnotation()
                a.coordinate = self.mapView.centerCoordinate
                return [a]
        }.bind(to: mapView.rx.annotations)

Is this expected behavior? Either way, I'd be happy to contribute to a binding that also handles the removal of annotations.

Don't know if it's just me, but I'm getting a crash when using Xcode 9.4 (9F1027a), Swift 4.1.2. Here's an example demonstrating the issue:

https://github.com/mkko/RxMKMapViewCrash

The issue is reproducible in simulator when building with Carthage. It seems that with CocoaPods everything's fine with same versions. I haven't tried manual setup yet.

There could be something I missed, but I've been using RxMKMapView without issues with Xcode 9.2 (9C40b), Swift 4.0.3. I'd be just happy to hear whether it is just me or if this issue is real.

Here's the stack trace of what I get:

I'm trying to add pod 'RxMKMapView', but get errors when I run pod install..

When I try to install, I get this error:

Analyzing dependencies
[!] Unable to satisfy the following requirements:

- `RxCocoa` required by `Podfile`
- `RxCocoa (= 3.2.0)` required by `Podfile.lock`
- `RxCocoa (~> 2.0.0-beta.4)` required by `RxMKMapView (1.0)`

Can't RxMKMapViewrun on RxSwift 3.x.x?

My Podfile.lock looks like this:

PODS:
  - Alamofire (4.3.0)
  - Analytics (3.5.7)
  - BrightFutures (5.1.0):
    - Result (~> 3.0)
  - Crashlytics (3.8.3):
    - Fabric (~> 1.6.3)
  - DonkeyLockKit (1.0.3):
    - BrightFutures
  - Eureka (2.0.0-beta.1)
  - Fabric (1.6.11)
  - INTULocationManager (4.2.0)
  - MBProgressHUD (1.0.0)
  - ReachabilitySwift (3)
  - Result (3.1.0)
  - RxCocoa (3.2.0):
    - RxSwift (~> 3.1)
  - RxSwift (3.2.0)
  - SwiftyJSON (3.1.4)

DEPENDENCIES:
  - Alamofire
  - Analytics (~> 3.0)
  - BrightFutures
  - Crashlytics
  - DonkeyLockKit (~> 1.0)
  - Eureka (~> 2.0.0-beta.1)
  - Fabric
  - INTULocationManager
  - MBProgressHUD
  - ReachabilitySwift (~> 3)
  - RxCocoa
  - RxSwift
  - SwiftyJSON

pod env:

Stack

   CocoaPods : 1.2.1
        Ruby : ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin16]
    RubyGems : 2.5.1
        Host : Mac OS X 10.12.5 (16F73)
       Xcode : 8.3.3 (8E3004b)
         Git : git version 2.11.0 (Apple Git-81)
Ruby lib dir : /Users/Martin/.rbenv/versions/2.3.0/lib
Repositories : donkeyrepublic - https://github.com/DonkeyRepublic/Specs.git @ e788fc19a90284afb8209d6cd4ec4f31734d0174
               master - https://github.com/CocoaPods/Specs.git @ e1e3036fa623439abda038279a53b9442cee1620

Installation Source

Executable Path: /Users/Martin/.rbenv/versions/2.3.0/bin/pod

Plugins

cocoapods-deintegrate : 1.0.1
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.2.0
cocoapods-try         : 1.1.0

Podfile

source 'https://github.com/DonkeyRepublic/Specs.git'
source 'https://github.com/CocoaPods/Specs.git'
# Uncomment this line to define a global platform for your project
platform :ios, '9.0'
# Uncomment this line if you're using Swift
use_frameworks!

target 'DonkeyProduction' do
	pod 'BrightFutures'
	pod 'Alamofire'
	pod 'MBProgressHUD'
	pod 'Fabric'
	pod 'Crashlytics'
	pod 'Analytics', '~> 3.0'
	pod 'SwiftyJSON'
	pod 'DonkeyLockKit', '~> 1.0'
	pod 'Eureka', '~> 2.0.0-beta.1'
	pod 'RxCocoa'
	pod 'RxSwift'
    pod 'INTULocationManager'
    pod 'ReachabilitySwift', '~> 3'
    pod "RxMKMapView"
end

target 'DonkeyProductionUITests' do
end

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['SWIFT_VERSION'] = '3.0'
        end
    end
end

The latest version of RxMKMapView on Cocoapods is 2.1.0 which isn't installable with RxSwift/RxCocoa 3.2.0. We're needing to reference the latest commit in our podfile to get it installing.
Could a new podspec release be done?
Same issue as RxWebKit RxSwiftCommunity/RxWebKit#7

I found the following delegate methods are not implemented in this extension:

func mapView(mapView: MKMapView, viewForAnnotation annotation: MKAnnotation) -> MKAnnotationView?
func mapView(mapView: MKMapView, rendererForOverlay overlay: MKOverlay) -> MKOverlayRenderer

How can I add a MKCircleRenderer to the map without this delegate?

It seems that (_ mapView: MKMapView viewFor: MKAnnotation) -> MKAnnotationView? isn't implemented, but I'm also noticing that it isn't getting called on my viewController. I realize this may not be a problem in RxMKMapView, but any theories as to why it's not getting called in my case? Several other RxMKMapView delegate methods (e.g., regionDidChangeAnimated) are getting called, as expected.