Code Monkey home page Code Monkey logo

rxcoredata's People

Contributors

ayastrebov avatar bobgodwinx avatar marshallxxx avatar maximelm avatar maxvol avatar samscam avatar scotteg avatar sergdort avatar serluca avatar simonrice avatar vandadnp avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

rxcoredata's Issues

Proposal for FetchedResultsControllerEntityObserver and FetchedResultsControllerSectionObserver

Issue

I had a performance issue using the rx_entities method.
The fetch request that I have to execute is heavy and it blocks the Main thread, and as expected the bottleneck is try self.frc.performFetch().
So I created another context with the concurrency type PrivateQueueConcurrencyType and I called rx_entities using the new context but nothing the try self.frc.performFetch() was still executed on the Main Thread because I was calling rx_entities on the Main Thread.

Proposal

What do you think about wrapping the try self.frc.performFetch() and sendNextElement() with performBlock? Or even better to schedule rx_entities on the context thread.

Crash on iOS 12 +

I am getting an unusual crash on devices > iOS 12 which seem to originate from FetchResultsControllerEntityObserver.sendNextElement().
Unfortunately, I am unable to recreate this as it happens randomly with devices from the App Store release. Seems related to #37. Here is a screenshot of where its happening, when mapping from CoreData model to a view model struct.

screen shot 2018-11-26 at 1 40 30 pm

Carthage Support

Carthage support would be a nice to have. I am happy to add it, if you are guys are cool with it.

Swift 3 support

Hi, guys I've already started some changes towards Swift 3.0 support.
If you don't mind I would like to continue working on it :)
So please add In Progress label

Pod trunk

Required

  • Pod trunk the release version 0.4.0

RxSwift 6.0 support

Hi and thank you for RxCoreData ๐Ÿ˜Š

RxSwift has released version 6.0.0 and I am getting an error updating our main project to RxSwift 6.0.0 because RxCoreData is still on 5.x

Would it be possible to update RxCoreData to RxSwift 6.0?

image

Does keeping a reference to Observer cause a retain-cycle?

I'm still getting familiar with RxSwift, especially with regards to its memory management. I'm not clear on "what" the observer is. So in FetchedResultsControllerEntityObserver, it keeps a reference to observer so it can send onNext events in the delegate methods. Is this not a retain cycle, because observer is being held by the FetchedResultsControllerEntityObserver and also (I might be wrong here) by the Observable it's created in? Or is this one of those scenarios where all the references are being held "down-stream" so you don't really have a parent<--> child retain-cycle, just two references to a child.

In the Observable.create( (observer) -> Disposable) call, who "owns" the observer?

Stewardship

I think @samscam initially created this repo, but hasn't been active lately. That's totally fin! Open source is all volunteer-based. But we should discuss future stewardship of this project.

rx.entities.asSingle() won't have a response to subscribe

This is a good library!

Here is a problem about transforming from Observable to Single object.
The code as following below

var rx = coreDataContext.rx
            .entities(InformationEntity.self, sortDescriptors: [NSSortDescriptor(key: INFO.UPDATE_DATE, ascending: false)])
            .map { list -> FakeEntity in
                var entity = FakeEntity()
                entity.infoList = list
                return entity
            }
            .asSingle()  // โ‡ doesn't work well.
            .subscribe {
                switch $0 {
                    case .next(let entity):
                        print(entity)
                    case .completed:
                        print("good")
                    case .error(let error):
                        print(error)
                }

I don't know if my usage has problems or not. If I don't use asSingle(), it works well. I just learn swift a little, sorry that I still don't understand swift well. Just let you know there's a problem about asSingle(). Thank you!

Create swift4.0 branch

Currently RxSwift is at 4.0.0-alpha, but you cannot use RxCoreData against it because of the dependency to RxSwift ~>3.0.

Relationship vs RxCoreData

Hello. I have some problems with the addition of relations RxCoreData. I think it would be nice if you add some examples to show how to do it.

SPM Support

Swift package manager support would be a nice to have. I create PR for this.

Extract Persistable

IMHO, mapping domain objects to NSManagedObject and vice-versa shouldn't be part of this library, main target is rx extensions of CoreData. (Mainly doing same as RxRealm)

Lower deployment target

Is this necessary to use iOS 9.1 as the minimum deployment target? As far as I know RxSwift and RxCocoa require a minimum dep. iOS 8.0 .
Can we lower the deployment target to iOS 8 ? I'll be happy to send a PR to do so.

The demo content is few

I can not update UI when using RxCoreData modify model

Through your project Can you tell me how to use RxCoreData

thank you very much

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.