Comments (7)
What's the use case for knowing the HTTP version? I'll look into making the remote_addr
available.
from rocket.
I believe in keeping the API as clean and simple as possible. If there's something that's unused 99% of the time with little reason to use it the rest, I don't believe that feature should be included. That may or may not be the case with exposing the HTTP version - I've personally never had a need for it. Still, I'll tag this "feedback wanted"; perhaps someone else has a good reason to have it exposed.
from rocket.
Well, I agree that HTTP version may not appear immediately useful. However, in general hiding this kind of information gives you little, while exposing as much as possible will definitely give your users things to experiment with.
from rocket.
Remote address is definitely useful. Many types of apps want to record the remote IP address for audit logs.
Itβs also quite plausible that you might want to implement things differently in HTTP/1.1 and HTTP/2.0, e.g. bundle things up for HTTP/1.1 or use server push of more smaller resources in HTTP/2.0.
from rocket.
I have no qualms about exposing the remote address. I'm looking for use cases on exposing the HTTP version. I'm not sure returning different responses depending on the HTTP version is something I want Rocket to encourage or allow.
from rocket.
Since no one has chimed in about a reason to expose the HTTP version, it will not be exposed.
from rocket.
e.g. bundle things up for HTTP/1.1 or use server push of more smaller resources in HTTP/2.0.
Why wouldn't you want to encourage this? Is there a better way to deal with bundled/unbundled resources in Rocket already?
from rocket.
Related Issues (20)
- Getting several lints on a #[derive(FromForm)] HOT 1
- Receiving ">>> Request guard `β¦` is forwarding" messages with log_level=critical HOT 6
- debug!("Received request: {:#?}", hyp_req); HOT 4
- Can't make private cookie not secure HOT 4
- Rocket does not return a 413 when the data submitted in a form exceeds the limit HOT 7
- Build fails with rustc<=1.68.2 HOT 3
- Update `hyper` to `1.0` HOT 1
- Conflicts among routes when `FileServer::rank()` function is used HOT 11
- Getting several no_effect_underscore_binding lints on #[launch] HOT 1
- Hello world example compiler error: macro-expanded `macro_export` HOT 2
- Handling of null bytes in forms is problematic HOT 6
- Improvements for the web serach: Content-Type, text/plain HOT 2
- Phase out async_trait macro HOT 2
- Recognise source maps in `ContentType::from_extension` HOT 2
- route rank clarification HOT 1
- Link to GitHub discussion from the web site HOT 1
- Supply PanicInfo to Catchers where applicable HOT 2
- (Solved) Rocket database fairing panicking while connecting to dockerized postgres on MacOS Sonoma HOT 1
- how to return error as a Json from FromParam HOT 3
- Responder enums not serializing like expected HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocket.