Code Monkey home page Code Monkey logo

Comments (4)

SergioBenitez avatar SergioBenitez commented on May 27, 2024 1

Perhaps! You should look at the response being sent by the server to confirm.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 27, 2024

I can't replicate this. I've tested this directly, and the secure flag is decidedly not set:

user_id=0qyN42VOqf5fe+cizPVrfDmgbRVovNtYFqYCCS8%3D; HttpOnly; SameSite=Strict; Path=/; Expires=Wed, 13 Dec 2023 00:31:32 GMT

Setting secure to false prevents Rocket from overriding the value. What's more, Rocket doesn't touch the value unless TLS is enabled:

if cookie.secure().is_none() && config.tls_enabled() {
cookie.set_secure(true);
}

(whoops! accidentally hit the close button!)

from rocket.

BastiaanOlij avatar BastiaanOlij commented on May 27, 2024

Very strange, I wonder if this is something that is being overruled on the browser side. I'm using chrome and looking at the cookie there it is set to secure. Could this be cause the cookie was created as secure at some point and the browser hangs on to that?

I'm currently not behind the system of the client but as soon as I can do some more testing (and also test with the 0.5.0 release) hopefully I can give some better feedback.

from rocket.

SergioBenitez avatar SergioBenitez commented on May 27, 2024

I'm going to close this out - it does not appear that this is a bug. Please let me know if you're able to confirm otherwise!

from rocket.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.