rwaltersma / mongokafkalite Goto Github PK

Asked DevEd DBX team for feedback on MongoKafkaLite fork and received these comments:

• ubuntu isn't a "lite" distribution. Not necessary to do now, but if you really care about size, you should use alpine linux and install tgz archives with apk .
• generally, in Docker files, when specifying images (e.g. (FROM ....:latest), you should specify exact versions rather than using latest or depending on apt-get to fetch the version that's compatible with the example. You'll find that you'll need to keep creating updated Docker files every time something it depends on reaches EOL (hopefully, not often), but that is expected maintenance. The only exceptions are when you're sure something will work with any version (not a great assumption).
• Re: config-data.js, do you actually need to create db and collection or does the connector do that for you?
• Maybe "source" isn't the best name for a collection since it's a term used to refer to other things like source connector.
• I see source-connector.json and sink-connector.json don't specify port in the connection uri but probably should.

In a review comment, Chris Cho raised a good point that the shell prompt should end in "$", ">", or "%".

Here is the initial comment.