rvflash / goup Goto Github PK

I was trying out goup today on a module that imports several private git repos. All the standard go commands work with my module and my GOPRIVATE settings. I explicitly set GOPRIVATE, and it appears that the go tooling set GONOPROXY and GONOSUMDB as well for me, as they all point to some private repos. I'm guessing that goup will need to read these env vars, as well as look at the .netrc file for credentials, as that is the recommended way to specify private git auth last I checked for go tools.

While investigating goup as a potential addition to our CI, I noticed that it uses src-d/go-git to discover available versions. As I was contemplating implementing something similar if I hadn't found goup, I was curious about this repository, but when I went to it, there was a notice at the top of its README saying that development had been moved to go-git/go-git. I would advise that goup should be updated to use the new go-git/go-git library.

Travis is now deprecated. Use Github actions with test coverage and golangci-lint.

Fix Dockerhub publishing.

For linting, I typically use golangci-lint, a very powerful multi-linter tool. It would be nice if goup was able to be integrated with that tool. This may or may not require output changes to goup to be compatible, which is why I'm suggesting it as an issue on goup as opposed to golangci-lint.

Since go1.21 : goup: invalid go.mod: go.mod:5: unknown directive: toolchain

for my repo I am getting following error

check failed: git: invalid repository: unsecured call to http://../ cancelled: failed to list tags

goup -v -m ./...

goup: github.com/xmlking/logger: github.com/pkg/errors v0.9.1 is up to date
goup: github.com/xmlking/logger: github.com/rs/zerolog v1.18.0 is up to date
goup: github.com/xmlking/logger: github.com/sirupsen/logrus v1.4.2 is up to date
goup: github.com/xmlking/logger/gormlog: ../ check failed: git: invalid repository: unsecured call to http://../ cancelled: failed to list tags
goup: github.com/xmlking/logger/logrus: ../ check failed: git: invalid repository: unsecured call to http://../ cancelled: failed to list tags
goup: github.com/xmlking/logger/logrus: github.com/sirupsen/logrus v1.4.2 is up to date
goup: github.com/xmlking/logger/logrus: github.com/pkg/errors v0.9.1 is up to date
goup: github.com/xmlking/logger/zap: ../ check failed: git: invalid repository: unsecured call to http://../ cancelled: failed to list tags
goup: github.com/xmlking/logger/zap: github.com/pkg/errors v0.9.1 is up to date
goup: github.com/xmlking/logger/zap: go.uber.org/zap check failed: git: invalid repository: unsecured call to http://go.uber.org/zap cancelled: failed to list tags
goup: github.com/xmlking/logger/zerolog: ../ check failed: git: invalid repository: unsecured call to http://../ cancelled: failed to list tags
goup: github.com/xmlking/logger/zerolog: github.com/pkg/errors v0.9.1 is up to date
goup: github.com/xmlking/logger/zerolog: github.com/rs/zerolog v1.18.0 is up to date

bug: only the latest are built

empty var?