Code Monkey home page Code Monkey logo

Comments (11)

alyssais avatar alyssais commented on June 3, 2024

I've also noticed lines like this:

// Portions Copyright 2017 The Chromium OS Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE-BSD-Google file.

But the LICENSE-BSD-Google file was removed in 85ab9e3 with a note saying "The vhost crate is written from scratch, so it should be licensed to Alibaba Cloud instead of Google." So is there code in this crate covered by that license or not? If there is, shouldn't that license file still be present?

from vhost.

Ablu avatar Ablu commented on June 3, 2024

@jiangliu: Can you clarify this? Those are all files claimed by Alibaba Cloud Computing:

❯ rg --before-context=1 'SPDX-License-Identifier: Apache-2.0$' -g '!rust-vmm-ci' -g '!crates/vhost-user-backend'
crates/vhost/src/vhost_user/message.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/mod.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/frontend_req_handler.rs
1-// Copyright (C) 2019-2021 Alibaba Cloud. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/dummy_backend.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/backend_req_handler.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/backend_req.rs
1-// Copyright (C) 2020 Alibaba Cloud. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/backend.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/frontend.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

crates/vhost/src/vhost_user/connection.rs
1-// Copyright (C) 2019 Alibaba Cloud Computing. All rights reserved.
2:// SPDX-License-Identifier: Apache-2.0

vhost-user-backend already is Apache-2.0 only. Should vhost be the same?

from vhost.

Ablu avatar Ablu commented on June 3, 2024

Related: rust-vmm/vm-virtio#283

from vhost.

jiangliu avatar jiangliu commented on June 3, 2024

Historically there are some code derived from crosvm project, so it should be "Apache-2.0 AND BSD-3-Clause".
I remembered there was an agreement to license code from project crosvm as "Apache 2.0". If it's true, I would prefer "Apache-2.0" instead of "Apache-2.0 AND BSD-3-Clause".

from vhost.

Ablu avatar Ablu commented on June 3, 2024

I remembered there was an agreement to license code from project crosvm as "Apache 2.0". If it's true, I would prefer "Apache-2.0" instead of "Apache-2.0 AND BSD-3-Clause".

Thanks for the clarification!

Is there some documentation around this agreement available?

from vhost.

jiangliu avatar jiangliu commented on June 3, 2024

The community has discussed about it in community meetings, but not sure whether it's documented.

from vhost.

Ablu avatar Ablu commented on June 3, 2024

@andreeaflorescu: Do you happen to recall details? 🤔 Would be great if we could reference some archival of the agreement.

from vhost.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.