Comments (3)
stefano-garzarella
commented on June 3, 2024
1
I just checked all the implementation of handle_event in https://github.com/rust-vmm/vhost-device and https://gitlab.com/virtio-fs/virtiofsd always return Ok(false) or an error.
And in
we handle properly theexit_event_fd, so I think we can avoid returning a bool.from vhost.
stefano-garzarella
commented on June 3, 2024
Yeah, every time I'm confused about that return value. I think we should improve the documentation or drop the return value if not needed anymore.
@jiangliu WDYT?
from vhost.
stefano-garzarella
commented on June 3, 2024
I'm going to post a PR, we can discuss there.
from vhost.
Related Issues (20)
- vdpa: Incorrect implementation of get_iova_range() HOT 3
- Vring addresses are not inside guest memory range if placed behind a vIOMMU HOT 10
- Mac build support HOT 5
- Typo `vhots v0.4.0` in GitHub Release HOT 1
- vhost: check better if `GET_VRING_BASE` message should reset the vring HOT 1
- Potential regression for vDPA support HOT 6
- Vhost crate point release for fixing vDPA regression HOT 5
- vhost-user-backend: Release new version (fix GET_VRING_BASE behavior) HOT 2
- Don't always enable vm-memory/backend-mmap
- Regenerate vhost_binding.rs and move custom changes in another file
- Missing Input Parameter Validation
- Remove non-standard BackedReq types
- ByteValued implementation for VhostUserInflight is UB HOT 11
- Inconsistent licensing HOT 11
- vhost: Migration of vhost_user device using ovs_dpdk as backend fails using Cloud Hypervisor on Ubuntu 22.04 host HOT 9
- Allow `Master` to set flags in the header HOT 4
- Add support for Inflight I/O tracking HOT 1
- Just a misoperation
- Change VhostUserSlaveReqHandler::set_slave_req_fd() to take an UnixStream instead of SlaveFsCacheReq HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vhost.