Firefox warns that the connection to the site is insecure because of images. I believe this is caused by the Rust logo image, which is being loaded from http://www.rust-lang.org/logos/rust-logo-256x256-blk.png (note the protocol). This might be fixed by changing http to https in the image src.

It's not a big deal, but it would be nice if it were shown as secure :)

Originally opened at nrc/rustaceans.org#647.

The bot should post an error message to the PR if it cannot be merged, and an error or success message to confirm it was added to the db, or if not, why not. It should include a direct link to the rustaceans profile

Useful to know when a person is likely to be around.

I've noticed a few queries for countries ("germany", "portugal"). Most likely, these people are looking for Rustaceans nearby.

We can either:

• Grab the location from the user's GitHub profile

• Add a "location" field to the data file. This duplicates the info from GitHub -- but given that we duplicate the "website" field already, perhaps this isn't such a bad thing.

Maybe

And maybe rename "discourse" to "internals discourse"?

According to the JSON standard, most Unicode characters such as "ń" are allowed to be put into strings unescaped. The code in this repo seems to be parsing the strings as ascii instead of utf-8, which creates an error for any unescaped unicode character.

crates.io's backend is written in Rust, and it works quite well. It would be nice if Rustaceans was too, especially as libraries like Hyper and Iron have cropped up in the mean time.

So that potential users can see what an entry looks like before adding themselves

If a user modifies multiple files, we should try to accept legit changes and ignore the rest. It seems to be pretty easy to do this accidentally, rather than error-ing out.

Bit trickier than the rest; Stack Overflow has unique userids (but not usernames -- these we'll have to fetch from the API, though they can be changed).

And leave an error message if so. This will protect against users who screw up the Git history (which happened over the weekend and caused the site to crash).

This line appears to contain an SQL injection:

  db.all("SELECT * FROM people WHERE blob LIKE '%" + search_str + "%';", function(err, rows) {

https://github.com/nick29581/rustaceans-src/blob/a86237571879b55a0a474d6efd4e8247f9ee26ff/backend/rustaceans.js#L85

iirc, I changed the process for adding new users so that it tries to add to the db, then merge if it was successful. We should do the same thing with changes to existing users.

e.g., from /search/nick to /nick29581

Currently we merge first, then read the merged file, then parse the JSON and populate the DB. Instead, we should read the JSON from the PR, try to put it into the DB and only merge if it is successful. Something to remember in this case is that the db will be ahead of the repo, so if we crash before merging we can't repopulate the db from the repo, we have to look at PRs too.

Take my detail page for example:
https://www.rustaceans.org/limuyuan

Current the link of "discourse username" will redirect me to http://discuss.rust-lang.org/users/limuyuan , but this website is unable to access.

Maybe it should be replaced to other available pages.

We should have a way to create the initial entry for a user without them going through the fork and submit a PR dance.

The work flow should be something like - login using GitHub auth, fill out a form on rustaceans.org (username should be supplied from the auth), create a json file from the form details, submit a PR of this json file to the rustaceans repo using the user's credentials. I think this is all possible using the GitHub API, and we probably don't need to actually have a copy of the repo on the server, we ought to be able to synthesise the PR.

On success, the user should get notified and get a URL for themselves on rustaceans and a URL to their data entry in the repo, and a URL and instructions for how to submit a PR to change their details.

(I'm not too concerned about having an interface to edit a user's details, although that is hopefully possible too - the rate of change is very low, and doing a PR is not too hard).

GitHub is, so we should be too

Discord is an increasingly popular way for rustaceans to communicate, we should consider adding it. I'm happy to make a PR for this if it's desired.