rudiedirkx / ethrly Goto Github PK

Password support for v2/20.

Encrypted DS returns 16 bytes for toggling a relay. ETH returns array of 1 byte. Toggling should return a bool, because the docs say what the right response is. Version specific.

Currently hardcoded (8 for v1 and 20 for v2). The only way to detect the number of relays is by hardcoding [module version => # relays]` and then do a version check, but that's too much. Just make it configurable. It's up to the user to do it correctly, like adding a password (only) if that's necessary.

No need for isPasswordProtected(). That's the user's responsibility.

unlock() should be protected.

Also protected: READ_BYTES(), STATUS_CODE(), VERSION_CODE(), dec201().

Very different from v2 password. Much better.

Add super simple logging interface, not a class. User has to write their own class. 1 or 2 methods should be enough. Useful and Verbose. In case you want to know every transported byte.

Both versions have a status/info/version command.

Every device does a few things. Interface those. Don't hint Ethrly1.

Rename unlock() to init()?, and add to interface.