rubyzip / rubyzip Goto Github PK

View Code? Open in Web Editor NEW

1.3K 40.0 314.0 2.73 MB

Official Rubyzip repository

License: BSD 2-Clause "Simplified" License

Ruby 99.89% Makefile 0.11%

rubyzip encryption ruby zip-extraction

rubyzip's People

Contributors

Stargazers

Watchers

Forkers

mwilson dv1 pascal-za dmgarland dlitz mezza funny-falcon ddonahue99 kungfucraig xaviershay williamn xaop justinlove fuzion24 jsanders kellydunn wpc dmarkow schmurfy whiteley btelles yaauie bmaddy nathanl rrmartins corecode rstrand ennova pavel-manylov cluesque marcuserronius nebj ideeli wolfer shipio stonefield n3phos yohansun brendon vliatsos jes5199 ricky26 beefcake ramdevbaba oogabooga jareda poshboytl quinnwilton crowdcompass die-antwort mdesantis amco superp cintamani sirupsen amatriain jphastings batter jimryan mperham crazymykl isendir srawlins loadhigh kitofr skoji plexus zacstewart meltingice davidhooey dholdren intrepidd arrtchiu iangreenleaf mrloop mehmetc diasks2 hainesr stain bkr layerssss muz yujideveloper vaneda lolgear jacobsimeon maneframe andreibondarev jastix johankok helabed feuda barnash matsu911 visser23 jaredbeck darinkes tingi syabruk porbas

rubyzip's Issues

License

Hi, is your license the same as Ruby 1.8 (GPLv2+ or Ruby) or Ruby 1.9 (BSD or Ruby)?

Thanks for the clarification,
Bohuslav.

rails 3 production - LoadError (cannot load such file -- zip/zip)

I'm using rubyzip to zip a csv file so uses can download it. This works perfectly in development mode. But when I tried zipping the file on the production server (rackspace) I received the error: LoadError (cannot load such file -- zip/zip). Is it a path issue? Anyone know a fix?

The error is being called in my code on this line: require 'zip/zip'

Zip::ZipCompressionMethodError: Unsupported compression method 98

Some versions of WinZip have a new compression method that's not compatible with rubyzip. Unfortunately, some users create such files.

Also see:
http://support.microsoft.com/kb/938319

`commit_required?` always true if CREATE supplied even when creation was not needed

Looking at the return for commit_required?, even if the zip file already existed and was read in, and no changes were required - commit_required? still returns true if you provided the CREATE flag in the constructor.

I've got a quick PR to discuss...

Avoid iconv on 1.9

When requiring rubyzip on 1.9.3, the following warning is issued:

.rvm/rubies/ruby-1.9.3-preview1/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in require': iconv will be deprecated in the future, use String#encode instead.`

New release of rubyzip gem

Any chance of getting a new gem cut to include the fixes in 0282627

no such file to load -- zip/ziprequire

Gemfile:

gem 'rubyzip', :require => ['zip/zip', 'zip/zipfilesystem', 'zip/ziprequire']

Useful Version numbers:
jruby 1.7.0.preview1 (ruby-1.9.3-p203)
rubyzip (0.9.8)

The error I am getting is "no such file to load -- zip/ziprequire" when running the tests for my app. I don't see this file in lib/zip like I do for zipfilesystem.rb and zip.rb. Was ziprequire removed?

Zip V1 compatibility

Suddenly i've met problem what there is problems with some legacy clients.

Problem is what recent version of ruby-zip produce zip, which require at least zip "v2" library to unzip them.

$ file legacy.zip 
legacy.zip: Zip archive data, at least v1.0 to extract

$ file modern.zip 
sync.zip: Zip archive data, at least v2.0 to extract

legacy.zip produced by ruby-zip 0.9.4 (November 2009)
modern.zip produced by ruby-zip 0.9.9 (lastest one)

with practically same code

Is there any way to enfore v1 compatibility? Is it worth to implement?

Error no such file using ZipOutputStream

Here's my code:

tmp = Tempfile.new("#{request.remote_ip}-#{Time.now.strftime("%Y-%m-%d-%H%M%S")}.zip")
filenames = []
begin
  Zip::ZipOutputStream.open(tmp.path) do |zos|
    files.each do |file|
      # ensure unique filenames so they aren't overwritten
      filename = File.basename(file)
      i = 1
      while filenames.include?(filename)
        filename = File.basename(file) + i.to_s
        i += 1
      end
      filenames << filename

      zos.put_next_entry(filename)
      zos.print open(file).read
    end
  end
  send_file(tmp.path, :type => 'application/zip', :filename => "User_#{params[:id]}_Tender_#{params[:tender]}.zip")
ensure
  tmp.close
  tmp.unlink
end

And here's the error I'm getting:

!! Unexpected error while processing request: No such file or directory - /var/folders/yt/m06sk6nj4bg8ppzs4nmw8k2r0000gn/T/127.0.0.1-2013-06-17-161959.zip20130617-3292-k5ls06

using version 0.9.9

`ZipFile.open` changes file permissions when combined with `Tempfile`

This is unexpected behavior and caused some trouble with file permission errors on serving files from rails through apache.

Replicated here:

# ruby-2.0.0-p247
require 'tempfile'
require 'zip/zip' # rubyzip (0.9.9)

def print_and_chmod(file)
  puts sprintf("%o", File.stat(file.path).mode)
  file.chmod(0640)
  puts sprintf("after file.chmod: %o", File.stat(file.path).mode)
  File.chmod(0640, file.path)
  puts sprintf("after File.chmod: %o", File.stat(file.path).mode)
end

File.write('foo.txt', 'foo.txt')

FileUtils.mkdir_p 'temporary_dir'
Tempfile.open('foo.zip', 'temporary_dir') do |tempfile|
  puts 'Before ZipOutputStream.open, Before ZipFile.open:'
  print_and_chmod(tempfile)

  Zip::ZipOutputStream.open(tempfile) { |zos| } # make sure it's a zip

  puts 'After ZipOutputStream.open, Before ZipFile.open:'
  print_and_chmod(tempfile)

  Zip::ZipFile.open(tempfile.path, Zip::ZipFile::CREATE) do |zip|
    zip.add(tempfile.path, 'foo.txt')
  end

  puts 'After ZipFile.open:'
  print_and_chmod(tempfile)
end

FileUtils.rm('foo.txt')

Which displays:

Before ZipOutputStream.open, Before ZipFile.open:
100600
after file.chmod: 100640
after File.chmod: 100640
After ZipOutputStream.open, Before ZipFile.open:
100640
after file.chmod: 100640
after File.chmod: 100640
After ZipFile.open:
100600
after file.chmod: 100600
after File.chmod: 100640

If you'd like me to turn this into a test for the suite, I'd be more than willing. I just need to know where to add it.

How define particular compression level when adding file to .zip?

I am using the code:

Zip::ZipFile.open('archive.zip') do |zip|
  zip.add('somefile.log', 'somefile.log')
end

But I need add this file with Zlib::NO_COMPRESSION level of cimpression.
Help, please. How I can do this?

Zip consistency problem while reading eocd structure

rubyzip fails to extract zip files because of exception mentioned in the title.

Every other tool I ve tried so far is able to extract these zip files.

Might it be possible to somehow get it work with rubyzip as well?

Thanks a lot in advance.

StringIO

Anyone want StringIO support?

InfoZip extra fields should be case insensitive

Another more concise way to add a directory recursively to a zip file

I've discovered this technique for recursively adding a directory to a zip file:

http://grosser.it/2009/02/04/compressing-a-folder-to-a-zip-archive-with-ruby/

The essence of it is:

Dir["#{path}/**/**"].each do |file|
  zipfile.add(file.sub(path+'/',''),file)
end

This loops over every entry in the subdirectory (recursively) and adds it in replicating the directory names in the zip file. Thought it would make for a more concise example in your samples section.

cannot set the file permission

the file permissions are always set to 0644 disregarding the value assigned to a file.
example:

filename = 'test'
zipfile = 'test.zip'

Zip::ZipFile.open(zipfile, Zip::ZipFile::CREATE) do |z|
z.file.open(filename, "w") { |f| f.write "created by rubyzip" }
z.file.chmod(0755, filename)
end

Zip::ZipFile.open(zipfile) do |z|
puts "perms: %o" % z.file.stat(filename).mode
end

outputs => perms: 100644
instead of 755

any suggestion?

thank you

Test failure with rubyzip 0.9.9

When running the tests with ruby 1.8.7 (2012-03-02 patchlevel 359) [x86_64-linux] I am getting the following test failure:

  1) Failure:
test_compound1(ZipFileTest)
    [/var/tmp/portage/dev-ruby/rubyzip-0.9.9/work/ruby18/aussiegeek-rubyzip-7260506/test/ziptest.rb:1465:in `assert_contains'
     /var/tmp/portage/dev-ruby/rubyzip-0.9.9/work/ruby18/aussiegeek-rubyzip-7260506/test/ziptest.rb:1403:in `test_compound1']:
entry data/generated/randomAscii1.txt not in data/generated/randomBinary1.bin, data/generated/empty_chmod640.txt, data/generated/longAscii.txt, renamedName, data/generated/empty.txt, data/generated/short.txt, data/generated/randomBinary2.bin in zip file 5entry_copy.zip.
<false> is not true.

Best way do it with new API?

I have a Rails controller method:

require 'zip/zip'

  def config_zip 
    tempfile = Tempfile.new('config_zip')
    Zip::ZipOutputStream.open(tempfile.path) do |z|
      z.put_next_entry("pass.txt")
      z.print 'Hello, Hello'
    end
    send_file tempfile.path, type: 'application/zip',
              disposition: 'attachment',
              filename: 'config.zip'
    tempfile.close
  end

It works perfect with 0.9.9 What the best way do the same with new api?

Is RubyZip thread safe?

I'd like to use it within Sidekiq. Thanks!

Temp files created in get_output_stream not unlinked

I have an issue when I am using rubyzip in a daemon and a lot of tempfiles are creeated (and persist) in the folder where I am creating the zip files.

This seems to be because the temp files which are created are not explicitly unlinked and remain on the disk until the ruby process ends or the tempfile objects are garbage collected.

TypeError: can't dup NilClass

I've been seeing the following stack trace when trying to create and write to a new zip file.

It happens sporadically, ie. not every single time, but enough to worry me. Wondering if someone could shed some like on it?

bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:44:in `dup'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:44:in `block in dup'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:44:in `map'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:44:in `dup'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:75:in `initialize'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:228:in `commit'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:242:in `close'
bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:92:in `open'

Add tests into gem

Hi,

It would be very nice to put the tests on the gem. I work with Gentoo and ruby and we use the tests to look for problems on a gem's installation.

File renaming is profoundly broken

Create a directory called test.
create four files inside that directory called: a, b, c, d
zip that directory with: zip -r test.zip test/

then execute this script:

  Zip::File.open('test.zip', "wb") do |z|
    z.each do |f|
      puts f.name
      z.rename f, "Z" + f.name
    end
  end

  puts "OUTPUT:

  Zip::File.open('test.zip', "wb") do |z|
    z.each do |f|
      puts f.name
    end
  end

the result is:

test/
test/b
test/d
Ztest/b
ZZtest/b
OUTPUT:
test/a
test/c
Ztest/
Ztest/d
ZZZtest/b

it seems that the entry are mangled while iterating over them with the z.each()

Error when uses Zip::ZipFile.open_buffer()

Hi,

I have the content of a zip file in memory and I need to get the content of some files.

This is a dummy example:

content = Assets.first.zip_content

zip = Zip::ZipFile.open_buffer(content)

And I got the following error:

/Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_entry.rb:212:in `read_c_dir_entry': undefined method `path' for #<StringIO:0x007faa4b859d30> (NoMethodError)
    from /Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_central_directory.rb:79:in `block in read_central_directory_entries'
    from /Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_central_directory.rb:78:in `times'
    from /Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_central_directory.rb:78:in `read_central_directory_entries'
    from /Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_central_directory.rb:86:in `read_from_stream'
    from /Users/ricardohsd/Work/Github/rubyzip/lib/zip/zip_file.rb:116:in `open_buffer'
    from teste.rb:15:in `<main>'

There is another way to solve this problem?

Feature Request: initialize from IO (File, StringIO) in addition to string path

Sometimes my zip documents aren't on my filesystem. Whether they're persisted to a database or available from an HTTP server, persisting them to my filesystem so I can use rubyzip is a step that causes the need for additional cleanup & additional points of failure. A possible solution would be to make Zip work with any instance of IO, to the point of being able to provide an instance of IO (such as File or StringIO) to the initialize method.

Correctly handle non ascii filenames & comments

RubyZip Crashes on Windows

We use RubyZip 0.9.9 on Windows and it crashes with the following error - we do have enough memory on this machine. The same works just fine on Linux.

   C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/inflater.rb:14:in `sysread': failed to allocate memory (NoMemoryError)
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_input_stream.rb:106:in `sysread'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/ioextras.rb:59:in `read'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/oddb2xml-1.1.2/lib/oddb2xml/downloader.rb:154:in `block (2 levels) in download'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry.rb:502:in `get_input_stream'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/oddb2xml-1.1.2/lib/oddb2xml/downloader.rb:154:in `block in download'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:35:in `each'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_entry_set.rb:35:in `each'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_central_directory.rb:109:in `each'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:132:in `block in foreach'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:90:in `open'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:131:in `foreach'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/oddb2xml-1.1.2/lib/oddb2xml/downloader.rb:152:in `download'
    from C:/Ruby193/lib/ruby/gems/1.9.1/gems/oddb2xml-1.1.2/lib/oddb2xml/cli.rb:32:in `block in run'

Any hints?

Best
Zeno

Unicode filenames do not work in Windows

I’m using Rubyzip 0.9.9 to create a zip archives containing filenames with accented characters on Mac OS and Linux computers. When I then extract those archives on Windows computers (using WinRar, 7-Zip or Windows’ built-in support for “compressed folders”), the filenames get mangled – most accented characters are replaced by 2 other characters, so it looks like the filenames are encoded as UTF-8 but interpreted by Windows as single byte encoding.

I found #3, but as far as I see, this pull request has never been merged.

Is this a known issue? Are there any workarounds?

If it’s possible to fix this with a sane amount of work I’d be glad to help – any pointers appreciated! 😄

Zip64 extensions

I'm working on a project that uses rubyzip to unzip files. The files I need to unzip have recently grown to over 4GB in size, making them unreadable with the current version of rubyzip. I'm contemplating adding Zip64 extensions to deal with this limitation. Read capability is my immediate need, and probably what would be initially implemented. Has any work/planning/discussion happened regarding Zip64 in this project? Thanks.

Filename too long

Here's the stack trace:

File name too long - /private/var/apps/markpond/releases/20130510121012/tmp/archive-zip/1/e2?url=http:%2F%2Fwww.aeonmagazine.com%2Fworld-views%2Fwill-wiles-technology-new-aesthetic%2F&title=The+machine+gaze&description=As+the+boundaries+between+digital+and+physical+dissolve,+can+the+New+Aesthetic+help+us+see+things+more+clearly?.html20130510-95137-8f42nk.lock
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:346:in `rmdir'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:346:in `rmdir'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:338:in `ensure in locking'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:338:in `locking'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:144:in `block in initialize'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tmpdir.rb:133:in `create'
/Users/alex/.rvm/rubies/ruby-1.9.3-p374/lib/ruby/1.9.1/tempfile.rb:134:in `initialize'
/var/apps/markpond/shared/bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_streamable_stream.rb:5:in `new'
/var/apps/markpond/shared/bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_streamable_stream.rb:5:in `initialize'
/var/apps/markpond/shared/bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:157:in `new'
/var/apps/markpond/shared/bundle/ruby/1.9.1/gems/rubyzip-0.9.9/lib/zip/zip_file.rb:157:in `get_output_stream'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:31:in `block in writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `each'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:29:in `block in writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `each'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:29:in `block in writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `each'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:22:in `writeEntries'
/private/var/apps/markpond/releases/20130510121012/lib/zip_lib.rb:14:in `write'

Not sure why this is an issue, given that OS X had no problem handling this kind of length of file outside Ruby. Also, interesting how it had no problem creating the file - it was the deleting (rmdir) that threw the error.

zip archive broken (CRC Error) on Windows when using utf-8 encoded string on Ruby 1.9.x

this code will reproduce the problem in the following environments:

ruby-1.9.3-p0 + MacOS X 10.7.3 + rubyzip 0.9.6.1
ruby-1.9.3-p125 + Windows 7 + rubyzip 0.9.6.1

'test_broken_on_1.9.3.zip' seems OK on MacOS, but can't extract on Windows 7 or Windows XP because of CRC error.

# -*- coding: utf-8 -*-
Zip::ZipOutputStream.open('test_broken_on_1.9.3.zip') {
  |zos|
  zos.put_next_entry('test.txt')
  zos << '日本語 Japanese Character in text.'
}

Zip::ZipOutputStream.open('test_not_broken.zip') {
  |zos|
  zos.put_next_entry('test.txt')
  zos << '日本語 Japanese Character in text.'.force_encoding('us-ascii')
}

Disable extra fields?

Hi, all. Is there an easy way to disable the extra fields entirely? What I'm looking for is something similar to what you get when using the -X option with command-line zip.

I'm trying to create epub documents. An epub container is just a zip file, but unfortunately the extra file attributes are not supported (this is arguably broken, but it's not within my control). zip -X works fine, but rubyzip doesn't.

Doc out of date.

FYI, it appears the doc are out of date one names. e.g.

Zip::File.open(zipfile_name, Zip::File::CREATE)

should be

Zip::ZipFile.open(zipfile_name, Zip::ZipFile::CREATE)

http://stackoverflow.com/questions/17956999/rubyzip-cannot-load-such-file-zip

split feature is non-compliant

The split feature implemented in Pull request 75 doesn't conform to the standard, in that:

Local and central directory header records must never be split across a segment boundary. (8.5.2) The rubyzip split code doesn't even look at the zip file content; it just blindly chops its up into fixed-size pieces.
The central directory entry for each file should indicate a disk number where the file starts (4.3.12); this is hard-coded to 0 in rubyzip.
The end-of-central-directory record should indicate disk numbers where the central directory begins and ends, and also the number of entries located on the last disk in addition to the total number of entries. (4.3.16) rubyzip is again hard-coded to assume there is only one disk.

(section numbers refer to version 6.5.2 of http://www.pkware.com/documents/casestudies/APPNOTE.TXT)

In addition, the test code doesn't test whether anyone might be able to read the split archive; it merely strings the pieces back together and tests reading the reconstituted file. The zip specification is, however, designed not to require stringing pieces of split archives together--or even generating a single big archive to begin with, as fogeys like me who remember spanning archives across floppy disks would know. It's designed so that the central directory and any particular file can be located in-place in their segment (or "disk"). rubyzip doesn't accomplish this.

rubyzip seems to break tempfile

tempfile_bugfixed.rb breaks mini_magick (3.3). MiniMagick create method creates a tempfile like this:

 tempfile = Tempfile.new(['mini_magick', ext.to_s.downcase])

According to the Tempfile docs this should work fine as passing an array for basename is supported: http://ruby-doc.org/stdlib/libdoc/tempfile/rdoc/classes/Tempfile.html

However, rubyzip's tempfile implementation generates a wrong file path, it doesn't seem to support an array:

/var/folders/ps/psLZoFzgHKSiegJINYpXAU+++TI/-Tmp-/["mini_magick", ""]47744-559602 (example)

How do I add rubyzip to a gemspec as a dependency?

In a Gemfile I can do:

gem 'rubyzip', :require => 'zip'

But how do I do the same in a Gemspec, the following does not work:

s.add_dependency 'rubyzip', :require => 'zip'

Add missing Zip::Entry arguments to Zip::File#get_output_stream

Using Zip::File#get_output_stream with a non-Zip::Entry instance as entry argument you cannot specify the other Zip::Entry arguments, like for example compression method.

This monkey patch allows it:

require 'zip'

module Zip
  class File
    def get_output_stream(entry, permissionInt = nil, comment = nil, extra = nil, compressed_size = nil, crc = nil, compression_method = nil, size = nil, time = nil,  &aProc)
      newEntry =
        if entry.kind_of?(Entry)
          entry
        else
          Entry.new(@name, entry.to_s, comment, extra, compressed_size, crc, compression_method, size, time)
        end

      if newEntry.directory?
        raise ArgumentError,
              "cannot open stream to directory entry - '#{newEntry}'"
      end
      newEntry.unix_perms = permissionInt
      zipStreamableEntry  = StreamableStream.new(newEntry)
      @entry_set << zipStreamableEntry
      zipStreamableEntry.get_output_stream(&aProc)
    end
  end
end

# example
Zip::File.open('test.zip', Zip::File::CREATE) do |archive|
  # enter a non compressed entry 
  archive.get_output_stream("first.txt", nil, nil, nil, nil, nil, Zip::Entry::STORED) { |f| f.puts "Hello from ZipFile" }
end

On Ruby 2.0: `read': can't set length of shared string

[Copy of http://sourceforge.net/tracker/?func=detail&aid=3498506&group_id=43107&atid=435170 -- I'm really confused where stuff is supposed to go and what's the official repo?]

I realize this is not quite a "proper" bug report, but this is as far as I got tracking down this issue -- I'm thinking it's a problem in rubyzip:

$ rbenv install 2.0.0-dev    # ruby 2.0.0dev (2012-03-07 trunk 34944) [x86_64-linux]
$ RBENV_VERSION=2.0.0-dev gem install selenium-webdriver
$ RBENV_VERSION=2.0.0-dev ruby -e 'require "selenium/webdriver";Selenium::WebDriver.for(:firefox, {})'
/home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/inflater.rb:42:in `read': can't set length of shared string (RuntimeError)
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/inflater.rb:42:in `internal_produce_input'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/inflater.rb:14:in `sysread'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_input_stream.rb:106:in `sysread'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:581:in `block (2 levels) in write_file'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:502:in `get_input_stream'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:577:in `block in write_file'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:576:in `open'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:576:in `write_file'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry.rb:205:in `extract'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_file.rb:188:in `extract'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/common/zipper.rb:27:in `block (2 levels) in unzip'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry_set.rb:31:in `each'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_entry_set.rb:31:in `each'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_central_directory.rb:113:in `each'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/common/zipper.rb:22:in `block in unzip'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/rubyzip-0.9.6.1/lib/zip/zip_file.rb:86:in `open'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/common/zipper.rb:21:in `unzip'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/extension.rb:38:in `create_root'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/extension.rb:17:in `write_to'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/profile.rb:193:in `block in install_extensions'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/profile.rb:191:in `each'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/profile.rb:191:in `install_extensions'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/profile.rb:76:in `layout_on_disk'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/launcher.rb:57:in `create_profile'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/launcher.rb:34:in `block in launch'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/socket_lock.rb:20:in `locked'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/launcher.rb:32:in `launch'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/firefox/bridge.rb:19:in `initialize'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/common/driver.rb:31:in `new'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver/common/driver.rb:31:in `for'
from /home/ubuntu/.rbenv/versions/2.0.0-dev/lib/ruby/gems/2.0.0/gems/selenium-webdriver-2.20.0/lib/selenium/webdriver.rb:61:in `for'
from -e:1:in `<main>'

The offending line reads:

@zlibInflater.inflate(@inputStream.read(Decompressor::CHUNK_SIZE, buf))

Zip::ZipFile#mkdir changes input variable

When you run this code, the @name variable changes:

Zip::ZipFile.open(archive_path, Zip::ZipFile::CREATE) do |zipfile|
  zipfile.dir.mkdir @name
end

For example, if @name is "my_dir" before the code, it will be "my_dir/" after.

Tag All Releases

E.g., tag v0.9.7 and v0.9.8, so that we can diff them by their tags and see what changed in the latest release.

Zlib::GzipWriter object must be closed explicitly

I'm using the Zip::ZipFile.open method to create a zip file. My log ends up showing the following…

zlib(finalizer): Zlib::GzipWriter object must be closed explicitly.
zlib(finalizer): the stream was freed prematurely.

I'm not really sure what's going on, particularly because I was under the impression that using the block variant handled closing everything up.

ZipInputStream broken

The following code only shows the first real file in the attached zip. The rest is not shown anymore.
Zip file created on Mac OSX.

Zip::ZipInputStream::open("eins.zip") do |io|
while (entry = io.get_next_entry)
pp entry
end
end

old zip files work.

but

Zip::ZipFile::foreach("eins.zip") do |entry|
pp entry.name
end

works for the same file.

Error during install.

Adding gem 'rubyzip' didn't seem to work for me. Found this answer, which solved the problem.

LoadError (cannot load such file -- zip/zip)

As of version 1.0.0 getting "LoadError (cannot load such file -- zip/zip)" when trying to launch our rails app both locally and on Heroku. App now won't start. Note that we don't use rubyzip directly . . . it is loaded as an axlsx gem dependency.

Worked fine on 0.9.9.

Rolling back to 0.9.9 for now.

Ben

Would you like some documentation help?

I like rubyzip, but had some initial trouble figuring it out. Once I got it working for my purposes, I wrote a short tutorial, which has been helpful for some others. My examples were intentionally silly, but I'd be happy to add something similar (but less silly if you like) to the README here.

Here's my blog post: http://sleeplessgeek.blogspot.com/2011/03/short-rubyzip-tutorial.html

And here's a library of my own, as another example of my documentation: github.com/nathanl/authority

Would you like a contribution to your README?

RubyZip not working on heroku

I am working with creating zip file after read users cv's. Code is working fine on local

machine. But there is error when deploy this code on heroku.

My code is below

require ''zip"

                   def  get_stream(contractors)
                       # contractors are all user records
                       t = Tempfile.new("#{Rails.root}/tmp/my-temp-filename-#{Time.now}") #this line on heroku break
                      begin
                          Zip::OutputStream.open(t.path) do |zos|
                            contractors.each_with_index do |contractor, index|
                            if contractor.cv.path
                                zos.put_next_entry("#{index+1}_# {contractor.full_name.parameterize.underscore}.#  {contractor.cv_file_name.split(".").last}")
                                zos.print IO.read(contractor.cv.path)
                           end
                       end
                       end
                       send_file t.path, :type => 'application/zip', :filename => "Contractors_cvs.zip", :x_sendfile => true
                      t.close
                  rescue
                    t.close
                  end

               end

while heroku logs --app just show me "Completed 500 Internal Server Error in 56ms"

Any help please.

Thanks

interaction with sinatra fails

after upgrading from rubyzip 0.9.1 to rubyzip 0.9.5 I receive an error in the output from thin when it tries to make a request to the second thin instance that is using sinatra. I have tried two versions of sinatra and three versions of thin and the error only appears when making the upgrade to rubyzip. Not sure what other information would be useful.

Error that appears
!! Unexpected error while processing request: undefined method `starts_with' for "SERVER_NAME":String

When rubyzip is used to modify a DOCX file, the resulting file can't be opened

Take a DOCX file (which is just a ZIP file with a different extension). Use Zip::ZipFile to remove one file from the archive, and replace it with an exact, identical one. The resulting file won't be openable by Microsoft Word, OpenOffice, etc.

require "zip/zipfilesystem"
f1 = File.binread("test.docx")
Zip::ZipFile.open("test.docx") { |z| s = z.file.read("word/document.xml"); z.file.delete("word/document.xml"); z.open("word/document.xml","w") { |f| f.write(s) } }
f2 = File.binread("test.docx")
f1 == f2 => false
f1.bytes.take(15)
=> [80, 75, 3, 4, 20, 0, 6, 0, 8, 0, 0, 0, 33, 0, 111]
f2.bytes.take(15)
=> [80, 75, 3, 4, 10, 0, 0, 0, 8, 0, 0, 0, 33, 0, 111]

After the ZIP file is read and written by rubyzip, a couple of bytes in the header are changed. I don't know enough about the ZIP format to understand why. But when I do the same thing with a standalone ZIP utility, it doesn't do that, and the resulting DOCX file can be opened properly.

Classes & Test Structure need a tidy up

name_in removed in commit f9b9a30b6f8c1b2613bc38841788e731a12ff720

This appears to be the (unintentional?) result of a refactoring, but the commit f9b9a30 removes name_encoding, name_in and comment_in methods from the ZipEntry class. Is there a different suggested way of fetching filenames with a certain encoding or is it possible to get these methods back?