Add test that the settings partial appears on partner profile edit about human-essentials HOT 6 CLOSED

Hi @cielf, can you assign me to this issue? Thanks!

from human-essentials.

You've got it!

from human-essentials.

@cielf In looking at where the partner_settings partial is used, there are two more places and I was wondering if I should include tests for these instances as well in my PR:

• Signed in as Partner, Profile Show view
• Signed in as Diaper Bank User, Edit Partner Information

from human-essentials.

There doesn't seem to be tests for presence of other partials in the Partner Profile Edit view, so I was curious why only this particular partial in only the specific edit view.

from human-essentials.

Huh. I would have thought we would have a test for the partials that are configurable already. We do for the area served, actually.
I think I'll write up a separate issue for the configurable partials, and for the other non-configurabale partials.
Please do include tests for Signed in as Partner, Profile Show view and
Signed in as Diaper Bank User, Edit Partner Information

from human-essentials.

As for why this particular partial -- a change that made it disappear got by testing and our local manual testing. I run through the proposed changes on staging on Saturday as a sanity check before we release on Sundays and caught it, but it could very easily have gone into production. It also happens to be something that most partners would not notice was missing, so there is a low chance that we would have learned of it's disappearance from our users.

from human-essentials.