[PACKS] #10 Add custom request units to Request export about human-essentials HOT 4 OPEN

@cielf I'm looking at this and in some of my test data was a bit surprised. For some reason I thought that this was supposed to (even before this change) have a column for every item from the org. But instead it has a column for every item for the exported requests. Is that what you expected too?

In which case if someone is exporting requests which have ONLY used "Adult Briefs (Small/Medium) (Packs)" then that is the only item column that would get exported, right? It wouldn't export the POSSIBLE units, only the ones that are used in any of the exported requests. That's what the code is leading to based on current behavior, but thought I'd check.

from human-essentials.

Or now that I'm reading the description again, it would be that if the item was used on ANY of the exported requests, go ahead and include a column for ALL of the units. In which case, I should include the implicit "Unit" unit too, right?

from human-essentials.

@cielf I'm looking at this and in some of my test data was a bit surprised. For some reason I thought that this was supposed to (even before this change) have a column for every item from the org. But instead it has a column for every item for the exported requests. Is that what you expected too?

In which case if someone is exporting requests which have ONLY used "Adult Briefs (Small/Medium) (Packs)" then that is the only item column that would get exported, right? It wouldn't export the POSSIBLE units, only the ones that are used in any of the exported requests. That's what the code is leading to based on current behavior, but thought I'd check.

The question of whether should all the items on the org be included? The easy answer would be yes, but/and a certain number of the items are not visible to partners, so I'm not so sure that it would be useful across the board(I know of one bank that only offers their assembled kits to the partners for direct request).

We could, perhaps, make it all items that are visible to partners -- that would, at least, be more stable under filtering -- but I'd wonder about whether we have banks that take things out of visibility to the partners when they no longer have a reliable supply of them. It's out of scope for this change in any case.

But I want to muse about this. Maybe ask the stakeholder circle for input on Wednesday.

from human-essentials.

Or now that I'm reading the description again, it would be that if the item was used on ANY of the exported requests, go ahead and include a column for ALL of the units. In which case, I should include the implicit "Unit" unit too, right?

Short answer -- I think yes (though my ultimate reason for thinking so is stability, informed by the discussion above) But also -- what if they delete a unit (which they can, right?) . There could be item requests using that unit -- so we would need to make sure those are included.

Edge cases, man.

from human-essentials.