[Bug] Fix nasty error when clicking on partner approval request email as partner about human-essentials HOT 18 CLOSED

All righty - good luck!

from human-essentials.

Go for it!

from human-essentials.

I can work on this

from human-essentials.

Hey @zeeshan-haidar - did you want this one or #3707 ?

from human-essentials.

@dorner I actually want both, I have already started working on #3707, I just don't wanna sit idle once I finish that #3707

from human-essentials.

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

from human-essentials.

This issue is in progress, already created PR

from human-essentials.

guh not sure why the bot is marking it as stale when the PR had changes 😦

from human-essentials.

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

from human-essentials.

Automatically unassigned after 7 days of inactivity.

from human-essentials.

I can pick this ticket up.

from human-essentials.

@dorner quick question! I'm new to this app and not sure what is the correct page to be displayed. Can you add some info on that? Thank you!

from human-essentials.

@thebkbuffalo I'd take a look at the original (now apparently abandoned) PR as a place to start looking: #3759

from human-essentials.

@dorner - question for you. I'm working out how data is associated, and have sorted out whats breaking here, but not sure the right way to fix it. These new Partners getting created don't have an associated Organization via roles (they only have Partner roles, not org roles) which is what's breaking links created on the _lte_sidebar.html.erb page. However, I'm not entirely sure these newly created Partners should have an associated Organization or not. Any light you can shed on these roles and what should be associated or not would be helpful. Thank you!

from human-essentials.

Partners all are associated with an organization (it's a 1-to-many, not many-to-many relationship). Partners themselves don't have roles, only partner users. So it would be partner user -> partner (via role) -> organization.

from human-essentials.

Sorry I mistyped in my last comment. I understand the association between Partners and Organizations. The question I was trying to get to was more about the association between Users and Organizations. The users created during the new partner creation process don't have any associated roles that correspond to organizations. So when the user clicks the Review Organization link, what's breaking is calling current_user.organization in the _lte_sidebar shared view because the User doesn't have any associated Organization via Roles, or more specifically Organization_Role.

So my real question is, should that association from User to Organization via Roles exist for these new Users whose only role is as a Partner? If so, then during the Partner creation process that Role needs to be created as well for the User. If not, may have to modify how we get that Organization data in the sidebar view.

Thank you again for the help!

from human-essentials.

created a PR fixing this bug.
#3965

from human-essentials.

Created a new PR with correct fix.

#3974

from human-essentials.