rubyforgood / coral Goto Github PK

The use of "fragments" does not imply 'broken'; it's a domain term for referencing each individual coral. We're not concerned with "broken" ... we are, however, concerned with the number of bleached coral; update the forms and the database columns accordingly.

Add documentation for the process of checking the offline behavior of the application.

We needed to temporarily disable internationalization to make fix the offline features. Basically, the locale part of the url was interfering with the service worker router. I believe this can be fixed by forming it as part of the path rather than a query parameter (\locale instead of ?locale).

Based on what Terrastories project did, which used this repo as a reference: https://github.com/github/scripts-to-rule-them-all

Record the number of coral removed for planting from a table. These are the healthy, successful coral!

Workflow for the demonstration should be smooth, such that we are able to complete all pieces without URL-hacking. We should be able to input meaningful data, and must be able to demonstrate that the system works while without a network connection.

• Demonstrate logging in to the application
• Begin a dive
• Input a new restoration activity
• shut down the server
• add a second restoration activity
• restore the server
• complete the dive
• Review the restoration activities associated with the dive
• upload new "table images" for each of the restoration entries
• Show each activity on a display not associated with the dive.

Extra:

• Demo the creation of a new zone and a new nursery table entry.

We don't want to allow the ability to remove old log entries here; let's start with just removing the destroy buttons from the existing views of restoration activities.

The form should be structured and styled in such a way that it's reasonable to fill out on a tablet while underwater. Large touch targets, obvious buttons, etc.

We should probably also remove / hide the File upload dialog during initial input. Everything here should be considered write-only, except for the image attachment, and that should be considered to be happening outside the context of an active dive, when these entries will be created.

Logging out should not be a trivially hittable link on the main navigation. It should be visually isolated, and probably prompt for confirmation before actually completing.

Potentially, it should not be accessible while the application is in offline mode.

Setup testing of JavaScript

Just need basic TL;DR setup instructions.

Rather than asking for "percents" in log entries, deal only in absolute numbers: Number removed, number added, etc.

Occupation percentages can be calculated using these details later, but we should keep the log entries as simple as possible.

Despite yarn install completing successfully during web container build, when running, I see the following error:

web_1       | => Booting Puma
web_1       | => Rails 5.2.3 application starting in development 
web_1       | => Run `rails server -h` for more startup options
web_1       | warning Integrity check: System parameters don't match
web_1       | error Integrity check failed
web_1       | error Found 1 errors.
web_1       | 
web_1       | 
web_1       | ========================================
web_1       |   Your Yarn packages are out of date!
web_1       |   Please run `yarn install --check-files` to update.
web_1       | ========================================
web_1       | 
web_1       | 
web_1       | To disable this check, please change `check_yarn_integrity`
web_1       | to `false` in your webpacker config file (config/webpacker.yml).
web_1       | 
web_1       | 
web_1       | yarn check v1.16.0
web_1       | info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.
web_1       | 
web_1       | 
web_1       | Exiting

The styling of btn given in the screen media query is overriding the usual btn-primary btn-danger specializations.

If we're aming to use different colors, we should configure the appropriate bootstrap sass variables. Button colors should not be changing based on screen size.

Should also be careful about a.btn and button.btn differences, as the usual intent is that they both display the same, as actionable buttons

Find a place to deploy to.

Need a Rails, NGinx host and s3 compatible storage for images.

For test / demo purposes, this can be a DigitalOcean team. For production, we need to poke around and see if we can get some sponsored / cheap deployment. RFG proper may have some leads on this, or I may be able to talk to someone at DO about getting credits / a free account.

I know the button styling went away a while ago, but on chrome, the sign in text does not appear to be a link. It's still ok on firefox.

Steps to reproduce:
Open the login screen on chrome, and hover over 'sign in'. The arrow should change style (from an arrow to a pointer finger usually). It does not.

Most things should be able to take a state. When "destroying" an object, rather than allowing it be deleted from the database, mark it in an inactive state. This prevents corrupting old data, while still allowing a notation of things that are no longer relevant.

Several existing views have not been internationalized yet. Rework those views to use the t(...) translate helper function, and add translations to the locale files for en and fr.

In a zone display, show the aggregate total numbers for that zone: how many coral currently on table, how many have bleached, how many have died, etc.

Most of the translations are in one big file that's getting difficult to find things in now. Re-organize translations into a folder structure that makes things easier to find, as mentioned in the docs here.

Viewing each nursery table should, at a minimum, display it's current status (zone, amount full, etc) and a most-recent-first history of restoration activites on that table. This list should be paginated.

Expected behavior:
New nursery table form should create a new nursery table associated with the selected zone. Form should populate a zone id based on the dropdown.

Actual behavior:
Attempts to create a new nursery table result in an error "Zone must exist" even if I have a zone selected:

In the console, I noticed that the form is using the zone name, rather than the id, to look for the zone.

Processing by NurseryTablesController#create as HTML Parameters: {"utf8"=>"✓", "authenticity_token"=>"XsLtVJiFRo1+QE3Z4GySTPUNReOrccOERlRoK5dSLiIDSZcHxCgFIyz8MTL/zlzQfW1sTwJODjodtUlSHP3NOQ==", "nursery_table"=>{"capacity"=>"200", "zone_id"=>"fa", "name"=>"fa"}, "commit"=>"Create Nursery table"}

Step to reproduce:
Create a new zone at /zones/new
Navigate to nursery_tables/new
Select your new zone from the drop down.
Fill in all fields with test data and hit "Create Nursery Table"
Observe errors in the browser and the rails console (you may need to scroll up)