Future interface about concurrent-ruby HOT 5 CLOSED

You're right, changing the API isn't an easy choice, but that's better than having a serious bug. I never gave any thought to subclassing Future because, in my mind, I view it like a concurrency primitive. But it isn't and you are correct that subclassing is a problem. What do you think about supporting execute as both an instance and a class method?

f = Future.new{ sleep(10); print "foo\n" }
f.state #=> :unscheduled
f.execute
f.state #=> :pending

f = Future.new{ sleep(10); print "foo\n" }.execute

f = Future.execute{ sleep(10); print "foo\n" }

In the both cases initialize raises an ArgumentError if no block is given. The instance method execute returns self to support the single-line chained call, but does nothing once the Future is in any state other than :unscheduled. The class method execute, as you suggested, creates a new Future, calls execute on the object, then returns it.

Thoughts?

from concurrent-ruby.

I like this solution, because new keeps the current signature and the whole class interface is nicer.
execute could take an optional thread_pool parameter, to make it more flexible: at the moment is not easy to change it, so in some situations we have a little messy code (like in tests)

from concurrent-ruby.

I've updated Future with the execute methods and updated the specs. I didn't implement a thread_pool parameter yet. I've struggled some with how best to handle internal thread pools. I'd like to handle that consistently for all abstractions that should reasonably support them. An optional parameter makes sense for Future but I'd like to look at the rest of the library and see how many of the abstractions that approach makes sense with.

from concurrent-ruby.

I noticed that ScheduledTask has the same issue as Future so I implemented the same execute methods on that class, too.

from concurrent-ruby.

I've also updated Future and ScheduledTask to have identical construction behavior. Both support Dereferenceable and take an options hash as a parameter to new and class execute.

from concurrent-ruby.