Code Monkey home page Code Monkey logo

Comments (4)

eregon avatar eregon commented on June 11, 2024

Mmh, I'm not sure how useful it would be, because any failure on such a job and not in regular CI would be a bug of RUBY_MN_THREADS=1, not concurrent-ruby. So at least it should not be part of the CI for PRs (AFAIK RUBY_MN_THREADS=1 is supposed to behave exactly the same as without).
But maybe it could be a daily/weekly job or so.
@ko1 Would that be useful? Or it's enough to run it locally when investigating https://bugs.ruby-lang.org/issues/19996?

It can also be that test failures are just transient errors, in which case they might or not relate to RUBY_MN_THREADS=1.

It might also be good to just try it and see, @luke-gru feel free to make a PR or run locally to see if setting that discovers anything interesting.

from concurrent-ruby.

ko1 avatar ko1 commented on June 11, 2024

@ko1 Would that be useful? Or it's enough to run it locally when investigating https://bugs.ruby-lang.org/issues/19996?

It would be helpful after we fix all of failures with MN threads. Now it doesn't have enough quality to check on CI.
(I'm planning to introduce MN enabled CI on ruby/ruby though)

from concurrent-ruby.

luke-gru avatar luke-gru commented on June 11, 2024

Makes sense, thanks! I thought it was already checked on cruby's CI but I guess I was wrong. Some of the MN thread implementation is being exercised by the ractor tests but I guess that's it.

from concurrent-ruby.

eregon avatar eregon commented on June 11, 2024

Closing this as there is nothing to do for now, and one can just open a PR after MN is stable enough and passing the test suite.

from concurrent-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.