Comments (4)
Mmh, I'm not sure how useful it would be, because any failure on such a job and not in regular CI would be a bug of RUBY_MN_THREADS=1
, not concurrent-ruby. So at least it should not be part of the CI for PRs (AFAIK RUBY_MN_THREADS=1
is supposed to behave exactly the same as without).
But maybe it could be a daily/weekly job or so.
@ko1 Would that be useful? Or it's enough to run it locally when investigating https://bugs.ruby-lang.org/issues/19996?
It can also be that test failures are just transient errors, in which case they might or not relate to RUBY_MN_THREADS=1
.
It might also be good to just try it and see, @luke-gru feel free to make a PR or run locally to see if setting that discovers anything interesting.
from concurrent-ruby.
@ko1 Would that be useful? Or it's enough to run it locally when investigating https://bugs.ruby-lang.org/issues/19996?
It would be helpful after we fix all of failures with MN threads. Now it doesn't have enough quality to check on CI.
(I'm planning to introduce MN enabled CI on ruby/ruby though)
from concurrent-ruby.
Makes sense, thanks! I thought it was already checked on cruby's CI but I guess I was wrong. Some of the MN thread implementation is being exercised by the ractor tests but I guess that's it.
from concurrent-ruby.
Closing this as there is nothing to do for now, and one can just open a PR after MN is stable enough and passing the test suite.
from concurrent-ruby.
Related Issues (20)
- why use wait_for_termination method will stuck the code HOT 2
- DaemonThreadFactory creating new Java thread factory each time it creates a new thread HOT 8
- `Concurrent::Promises::Future#value!` can return `nil` even when promise is not resolved yet HOT 6
- Version 1.2.2 crashes with Segmentation fault HOT 3
- Fiber.new causes SEGV when using Ruby 3.3.0 on Rails 7.1.2 in M1 Mac Docker environment HOT 5
- Segfault in lock_local_var.rb on aarch64 HOT 3
- [REDIRECT] Segfault on Ruby 3.3.0 on linux-aarch64? See https://bugs.ruby-lang.org/issues/20085
- Add API to prestart threads in threadpools HOT 4
- Don't know how to build task 'parallel_spec' HOT 2
- Segmentation fault related to concurrent-ruby HOT 4
- Segmentation fault with Ruby 3.3.0 running with Docker HOT 1
- Add keyword arguments to async HOT 1
- ThreadPoolExecutor#shutdown? inconsistency in JRuby and C Ruby HOT 4
- test failure due to "uninitialized constant Concurrent::CAtomicReference" HOT 7
- CAtomicFixnum should probably be a private constant HOT 1
- support re-raising exceptions when shutting down a timertask HOT 4
- v1.2.0 release notes do not mention that RubyThreadLocalVar class was removed HOT 8
- NameError: uninitialized constant Concurrent::RubyThreadLocalVar HOT 1
- The Concurrent::Map default_proc is passed a Concurrent::Hash instead of the Concurrent::Map HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concurrent-ruby.