Indentation on multi-line method calls about ruby-style-guide HOT 7 CLOSED

Just because I'm new to the ruby community, why is this not something people do:

Mailer.deliver(
  to:      "[email protected]",
  from:    "[email protected]",
  subject: "Important message",
  body:    source.text
)

Scatches the alignment itch without looking too adhoc with the bracket placement. Yeah, it's 2 extra lines, but that separation is at a visually useful place. And vertical space is in abundance, while horizontal space is a commodity. Adding 8+x extra spaces per line (where x can approach infinity) seems like funny use of space when 2 would do :)

But hey, guessing it's just how it is, hey

from ruby-style-guide.

Just to throw in my two cents:

Mailer.deliver(
  to:      "[email protected]",
  from:    "[email protected]",
  subject: "Important message",
  body:    source.text
)

It preserves alignment of keys and values, maintains the symmetry of indentation for lines containing opening parens and closing parens (e.g., flush with the current indentation), and preserves a constant two-space indentation for all circumstances (I can't seem to stand indentation of anything other than exactly two spaces at a time).

from ruby-style-guide.

Definitely. My experience shows that the aligned style is the most popular style (and it's also my preferred style). Note that in that your example there is only one method param.

from ruby-style-guide.

Oh yes, oops, I'm so used to supplying hashes to methods! Although a hash is probably most common when a method needs a lot of config passed.

from ruby-style-guide.

#I quite like these kind of things, but they're both very adhoc
Mailer.deliver(to:      "[email protected]",
               from:    "[email protected]",
               subject: "Important message",
               body:    source.text)

#or inspired by rubinius stack traces:
Mailer.deliver(to: "[email protected]",
             from: "[email protected]",
          subject: "Important message",
             body: source.text)

from ruby-style-guide.

Ah, yep. That's exactly what @patcon suggested.

from ruby-style-guide.

👍 to the suggestion by @patcon and @stouset, the extra horizontal space is invaluable, especially if dealing with an 80-character line limit.

from ruby-style-guide.