Code Monkey home page Code Monkey logo

Comments (2)

bbatsov avatar bbatsov commented on May 23, 2024

I don't get this part at all:

# bad - non explicit array name
results = electric_appliance.process!
results.each { _1.taste }

Seems like an OK usage to me, if this has some side effects.

I think the code bellow is OK, even if it'd stick to the older shorthands.

# bad - block can be created from method
waffles.each { _1.taste } # => waffles.each(&:taste)
waffles.each { taste(_1) } # => waffles.each(&method(:taste))

from ruby-style-guide.

Hugo-Hache avatar Hugo-Hache commented on May 23, 2024
# bad - non explicit array name
results = electric_appliance.process!
results.each { _1.taste }

I view the usage of numbered parameter bad in this case because by removing the variable name, you loose information on what you manipulate (as the array name is not specific enough). Here for instance the code below would have been easier to understand:

results = electric_appliance.process!
results.each { |waffle| waffle.taste }

I understand this part is quite subjective so it would not surprise me it would not fit in the style guide.

from ruby-style-guide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.