Handle numblock in each cops about rubocop-ast HOT 4 CLOSED

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

from rubocop-ast.

I'll see what I can do.

I agree with you that it should work out of the box as much as possible. I would alias on_numblock to on_block; cops that want to do something different can override it but by default it would work. What do you think of Block#arguments returning an array of Nodes like (arg :_1) instead of [] as currently, to make it even more similar?

I'd be tempted for block_type? to be true even for type == :numblock, but maybe it's best to define a common genblock_type?

Transferring to rubocop-ast

from rubocop-ast.

I haven't seen any issues with using alias on_numblock on_block, and there's even an InternalAffairs/NumblockHandler cop now.
At least in rubocop-rspec we often disable the cop and skip aliasing, as certain DSL methods don't yield arguments to their blocks, and numblock handling is redundant, like in let(:foo) { "bar" }.

Is there anything actionable left here?

from rubocop-ast.

Thanks for the feedback. Let's close then

from rubocop-ast.