`ProcessedSource#ast_with_comments` doesn't differentiate between identical nodes about rubocop-ast HOT 4 CLOSED

Indeed, this is surprising 😅

This was noted in whitequark/parser#184: "Note that {associate} produces unexpected result for nodes which are equal but have distinct locations; comments for these nodes are merged."

The proposed fix was associate_locations that does the same but uses the location as key.

IMO, a better method than either of them would be associate_by_identity, which does not use eql? but equal?. I'm proposing a PR for this: whitequark/parser#798

I believe that we could modify our ast_with_comments to use that without any incompatibility, but I didn't double check yet.

from rubocop-ast.

As I expected, tests pass on master.
Released in 1.4.2 👍

from rubocop-ast.

Released 1.5.0...

from rubocop-ast.

Thanks for the quick work @marcandre! 🎉

from rubocop-ast.