rterp / javafxpropertyhelpernbplugin Goto Github PK

Much in the same way the vanilla Java getter/setter generator allows you to generate getters and setters separately through different menu items. A dialog allowing you to choose which fields will have code generated is also a nice feature to add.

Create alternative forms for getter and setter

• Inspired bei Alexander Casall (über Twitter)
• http://blog.netopyr.com/2012/02/02/creating-read-only-properties-in-javafx/
• https://github.com/Naoghuman/Dream-Better-Worlds/blob/master/DBW-File-Dream-Api/src/main/java/de/pro/dbw/file/dream/api/DreamModel.java
• Low priority

Hi Rob

about the position from the action in the popup 'Insert Code..'. I see that the order is:

• ...
• Getter...
• Setter...
• Getter and Setter...
• ...

I think that the natural order from the new action in the popup were directly after the action 'Getter and Setter...'.

What the name from the action concerns:
When you open the menu in a JavaFX application you can see the actions

• ...
• Add Property...
• Add Java FX Property...
• ...

at bottom. With the 'Add Java FX Property...' you can create new properties and then the 3 methods from the variable. So I think a better naming were 'Java FX Getter and Setter...'.

• 'Java FX' both FX uppercase :) its the trademark from JavaFX. Normaly there is no empty space between 'Java' and 'FX', but NetBeans write the space in 'Add Java FX Property...'.
• The word 'Props' I have remove, because the action dont create the property.
• The action will be create 1 Setter and 2 Getter.
• 'Getter and Setter...' will follow the naming convention in NetBeans.

So what do you think about it? I have prepared my fork when you will have a look.

Greetings
Peter

Hi Rob,
I have done a litte analyse in reference for generic generation and seen that with the plugin the functionality for the generation from the getter and setter is doubled.

The plugin add the functionality for generating getter and setters immediatly with the new action 'JavaFx Getter and Setter...', but also the standard functionalities in the actions 'Getter..., Setter... and Getter and Setter...' in the popup 'Generate' will generate JavaFx getter and setter after the selection from JavaFx properties in the 'Generate Getter (and Setter) panel' (when also the generated sourcecode dont follow the JavaFX Naming Convention and the third method is missing).

So what I see to solve this problem is

• We can remove the standard actions from NetBeans and extend the new action from the plugin so that it also can generate normal Java properties.
• We can extend the standard actions from NetBeans so that they can also generate JavaFX properties which follow the JavaFX Naming Convention and add the third method. But then we dont need the new action.
• Its also possible to extend the standard action and the new action but this solution I guess is not so clean (double work).

For the second solution I have the idea to extend the 'Generate Getter (and Setter) panel'. At top then there is the JTree 'Select Java fields for generate...' and below a new JTree 'Select JavaFX fields for generate...'. What also speak for the solution with the extension from the standard actions is

• that the standard actions have the selection panel
• the standard actions can generate generic methods

In netbeans 8.2 the pluggin does not appear in the pluggins downloads...

This would be very handy.

Get, Set and property methods that are generated should be declared as "final".