Setting color to outside circle with cropToCircle = NO doesn't work about rscolorpicker HOT 5 CLOSED

Could you post the RGBA values of the 2 colors? The edges of the square are just the pixels from the radius of the circle, the square functionality is simply an interface tool for places where having a circle UI component looks out of place.

from rscolorpicker.

This is the color I want to set the picker to in Square mode (cropToCircle is NO): 1.000000 0.000000 0.752941

If I do [_colorPicker setSelectionColor:[UIColor colorWithRed:1 green:0 blue:0.752941 alpha:1]];

The resulting selected color is 1.000000 0.003922 0.749020.

I understand what you are saying but from a UI and functional point of view, this is not the correct behavior. If you give the user the ability to choose a color from a square area, you must let the app set colors in that area, otherwise what is the point.

from rscolorpicker.

I'm not making an argument against you, I'm just verifying that the values are actually different.

At this point I would agree that this is a bug.

The first place I would look is where we pad the circle for touch-input. I might be able to look into this more closely in the next week or two. But of course, pull requests are welcomed 😉

from rscolorpicker.

Could you reevaluate this issue based on the current state of master?

from rscolorpicker.

I tested setting the color and watching the callback, and it appears to be working as-expected now. One thing to note is that if the user drags outside of the circle area to pick the color, calling -setSelectionColor does limit it the position to within the circle, as the actual color value is the same (and the algorithm that generates it has bounds).

However, if you want your app to work based on position you can use -selection and -setSelection, rather than -selectionColor and -setSelectionColor.

I'm going to close this issue as there hasn't been any activity, but if anyone notices something weird like this just comment and I'll re-open, or create a new issue if you'd like.

from rscolorpicker.