Code Monkey home page Code Monkey logo

proceduralfairings's People

Contributors

bpolge avatar e-dog avatar itmustbeacamel avatar markushaslinger avatar nathankell avatar rsparkyc avatar starstrider42 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

proceduralfairings's Issues

NullReferenceException spam caused by attaching an interstage adaptor to an engine that has a shroud.

For KSP v1.4.3.2152; PF v1.4.3.2
When the top node of an interstage adaptor 'KzInterstageAdapter2' is attached to an engine that has a shroud (Spark) a NRE repeats until the engine is deleted.

NullReferenceException: Object reference not set to an instance of an object
at ModuleJettison.FetchActiveMeshTransform (System.String nameList) [0x00000] in :0
at ModuleJettison.LateUpdate () [0x00000] in :0

This doesn't occur if the engine doesn't have a shroud (Ant)

image

1.4.3.4 issue in early career - log spamming in VAB

I try to attach a PF base, after it is attached I disable Interstage Nodes, I detach it and can't reattach it.

I scrap it and try it with another one.
No avail.

Available sizes are 1.00m to 1.5m.

Log spam:

NullReferenceException: Object reference not set to an instance of an object
  at Keramzit.ProceduralFairingBase.HasNodeComponent[ProceduralFairingSide] (.AttachNode[] nodes) [0x00000] in <filename unknown>:0 
  at Keramzit.ProceduralFairingBase.recalcShape () [0x00000] in <filename unknown>:0 
  at Keramzit.ProceduralFairingBase.Update () [0x00000] in <filename unknown>:0 
 
(Filename:  Line: -1)

Fairing collider doesn't have enough polygons with only 1 faring node

I don't know how to show collider mesh in ksp (I read that unity editor has this feature, but you can't do it running outside of it?), hopefully these FAR voxels show the issue. The colliders are actually like this (not a FAR bug), I tried pushing it with a kerbal and the cylinder gets rotated like it's a square.

The attachment node are is on the right:
screenshot0

With 2 nodes it also looks rough:
screenshot1

version 1.4.5.5
ksp 1.4.5

Cannot detach fairings

I seem to be having a problem where the button for detaching fairings have disappeared. I'm using v4.0 with KSP 1.3.1

Staging and ActionGroups problems

Hello, some small problems comes up with the last Version

  • it's not possible to set the Fairings on an ActionKey
  • right click on the Staging Symbol and chose 'jetisson' release only the first of n: fairing-parts
  • while the Fairing is not jetissoned, MechJeb can't display/calculate the Stages

all other is great!

Mod should not alter stock fairings

After installing ProceduralFairings, ships created with stock fairings do not work properly - they need procedural fairings to be attached. Also, stock fairings are renamed, for example AE-FF1 becomes AE-FF-PF.
Being a parts pack, the expectation is that it does not alter existing parts, so that ships created without the mod do work properly and in a predictable manner.

Incompatibility with ReStocked mod deployable antennas.

I reported this problem on ReStocked github page, they suggested to post it here. Original issue: PorktoberRevolution/ReStocked#554 The problem occurs when using HG-5 or HG-20 deployable antennas. ReStocked upgraded these antennas with the axial position model, which is perpendicular to the radial one (which works just as the stock one). Only one model is visible in-game, other models are available as versions. However, ProceduralFairings "sees" hidden models as well and generates huge fairing to cover them all.

fairing sides just fall off

cue Clarke & Dawe, "The front fell off":

I'm having a problem with proc fairing sides falling off at the slightest provocation. Like, the when rolling out the vessel or when landing (doesn't need to be a very rough landing). Having KJR or not doesn't make the slightest difference. It's not 100% reproducible but even a little jolt has a significant chance of triggering the issue.

Just now it happened to a vessel floating in space while I was moving about unrelated parts with KIS.

Player log of the game session: http://ksp.schnobs.de/stuff/fairing_loss_Player.log.gz (35MB unzipped). The following might be useful search terms in the lengthy log:

ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
  at System.Collections.Generic.List`1[UnityEngine.ConfigurableJoint].get_Item (Int32 index) [0x00000] in <filename unk
nown>:0 
  at PartJoint.OnJointBreak (Single breakForce) [0x00000] in <filename unknown>:0 
(Filename:  Line: -1)

1.4.5.5 Fairing Base Decoupler Staging Not Available in VAB

KSP 1.4.5, with Procedural Fairings 1.4.5.5 (via CKAN)

(Technical: Unable to set KzResizableFairingBase 's MODULE[ModuleDecouple].stagingEnabled to True. It is unset in KzInterstageAdapter2 but set to False in KzResizableFairingBase)

The Payload Fairing - Base (Extended) does not show a staging icon when added in VAB. The fairing staging works as expected, the payload base is the issue. Right-clicking the part gives the expected menu items (Extra radius, strut/size toggles, fairing nodes, interstage toggle, size tweakable, mass, cost, decoupler force percent, crossfeed toggle) but nothing to enable staging. The decoupler can be activated by action group or right-click menu on the payload base during flight. Seems the toggle got lost from the GUI?

Non-scripting workaround is add a separate decoupler part above the payload base.

Scripting workaround (assuming you will ALWAYS want to use the decoupler?):
@part[KzResizableFairingBase]:AFTER[ProceduralFairings]
{
@module[ModuleDecouple]
{
%stagingEnabled = True
}
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.