rs117 / rlhd Goto Github PK

a. Shadow started following me around after teleporting out of barrows.

b. Windows
Intel i9-9900k CPU
32 GB RAM
64 bit system
Nvidia GeForce RTX 2060 SUPER

c. rectangle shadow started following me around after teleporting out of barrows chest room. Turning the shadows setting off and on fixes it. From what I've seen so far there's an about 50% chance of it happening.

Brimhaven agility arena needs some love too.
It seems like it didn't get alot of attention, understandably (there are more important places).

117 hd:
http://prntscr.com/1s31mkb

gpu:
http://prntscr.com/1s31pbk

a. With roofs turned on in POH the portal nexus shadow shows on the roof
b. i57600k, gtx1070, 16gb ram
c. In POH

Right-Clicking at Pest Control causes the water under the boats to lose the HD texture
Pictures for reference:

Before:

During Right-Click:

Small issue but wanted to help out. Nice job on the plug-in!

after i fixed the green stripes thru another graphical change to my Laptop the plugin worked and the stripes were gone, now i have a little delay on everything i do

Walking around practically anywhere into a chunk I haven't loaded in this instance, gives this

OpenCL code will need to be copied over from the GPU plugin and extended to support the normals buffer

client.log
Plugin will turn on but immediately turn off.

I read the FAQ stating to "turn off GPU" if the plugin crashes Runelite, so I checked the Runelite configuration tab to turn it off, but it was already off...
So I'm not sure why but even with that turned off, the plugin installation still crashes Runelite and wont work.

When changing fog depth mode, if static fog depth is set to 0, textures glitch out.

here is a recording, including my neofetch https://www.youtube.com/watch?v=6RPRBh8SZ1Q (video is unlisted)

tried on my brother's windows 10 pc with the same result

Downloaded the plugin and doesnt, do anything turns off after you turn it on... is there anything specific to do to make it work?? any help would be appreciated

Win10/r9 370/first area load

client.log
Screen flashes back and forth like that in Grand exchange.

a. What exactly happened? Try to include a picture if you can!
Was working fine then suddenly froze up with audio stuck repeating. Had to do a hard reboot

b. What are your system specifications?
Operating System
Windows 10 Pro 64-bit (OS Build 19043.1165)
CPU
Intel Core i5 8265U @ 1.60GHz 57 °C
Kaby Lake-U/Y 14nm Technology
RAM
16.0GB
Motherboard
Dell Inc. 0PYRY5 (U3E1)
Graphics
Generic PnP Monitor (1366x768@60Hz)
Intel UHD Graphics 620 (Dell)
Storage
238GB Micron 2200S NVMe 256GB (Unknown (SSD))
Optical Drives
No optical disk drives detected
Audio
Realtek Audio

c. What you were doing at the time of the bug
Killing a hob goblin and picking up snape grass near the crafting guild

d. Anything else you think could be used to help reproduce the error!
Nope

e. Include your client.log file!
client.log

Here's an image showing my issue.
I didn't do anything to cause this bug and can likely be repeated on different devices.

Specs:
AMD Ryzen 5800H
16GB DDR4 RAM
Windows 10
NVIDIA 3060 GPU

Describe the bug
Shadow distance reduces the quality of shadows. "Shadow resolution" works as intended and sharpens the shadows, however the distance setting will impact resolution regardless of the resolution setting.

To Reproduce
Steps to reproduce the behavior:

1. Increase/decrease "Shadow Distance" which will impact show resolution

Expected behavior
Shadow draw distance to increase without impacting quality

Screenshots
Here are some combinations for example:

Shadow Resolution: 8192
Shadow Distance: 20

Shadow Resolution: 1024
Shadow Distance: 20

Shadow Resolution: 8192
Shadow Distance: 90

Shadow Resolution: 1024
Shadow Distance: 90

Environment (please complete the following information):

• OS: Windows 10
• RuneLite version: 1.7.24
• Launcher version: 1.6.0

Additional context

When I try to enable any of the Anti Aliasing options, the upper and right side of the screen glitch and won't work properly, as if only a certain screen resolution is rendered rightly.

My laptop got an intel i7700HQ CPU, 8GB of RAM and my video card is an nvidea gtx 1050ti

I'm adding a gif of me replicating the glitch. It happens in every area of the game just by enabling any MSAA settings and won't stop glitching ever.

Shadows cast by a roof disappear when the roof is hidden. This makes things in the interior of buildings cast a shadow from the sun, making things look a bit odd.

Would it be possible to have an option to always take roofs into account when calculating shadows, regardless of if it's hidden or not?

Example showing shadows cast inside of a building:

Currently the dorgesh-kaan lighting is very very dark. It looks like there is no light actually produced by the in game light polls.

Not present

Semi Present

Water doesn't seem consistent.

Similar issue to
#5

setting it to static/dynamic seems to fix issue

i9-9900k / RTX 2070

Seems like the Cemetery Portal and Weiss Portal animations are broken.

Please check if your issue is not a duplicate by searching existing issues

Describe the bug
I think this probably has to do with my computer configuration. When I teleport to Priff, the game crashes. When I try to sign back in, it still does not work, if I toggle this plugin off then sign in, it works fine, but I can't turn the plugin back on.

If it helps, I had been experiencing this for a long time with the GPU plugin as well, but that's been more rare as of late, and it was inconsistent anyway.

To Reproduce
Steps to reproduce the behavior:

1. Teleport to Priff
2. Runelite freezes and you have to kill it

Expected behavior
I teleport to Priff and it does not freeze

Environment (please complete the following information):

• Windows 10
• RuneLite version: 1.7.24
• Launcher version: 2.1.7
• GPU: RTX 2070 Super
• Shadow Play disabled
• Driver is up-to-date
• Processor: 9900k
• I launch via command line because otherwise I have artifacting happen in runelite (I have a comment in this thread: runelite/runelite#11727 (comment)), and it could be related
• 32GB of RAM. I see it looks like an out of memory exception, but not seeing memory issues in my task manager, maybe video memory
• 3x27" Monitors 1440p@60hz, gsync enabled, full screen layout (obviously only play on one monitor)

Additional context
Logs associated with crash:

2021-09-13 16:06:30 [main] INFO net.runelite.client.RuneLite - RuneLite 1.7.24 (launcher version 2.1.7) starting up, args: none
2021-09-13 16:06:31 [Preloader] INFO net.runelite.client.rs.ClientLoader - Using cached vanilla client
2021-09-13 16:06:32 [Preloader] INFO net.runelite.client.rs.ClientLoader - Using cached patched client
2021-09-13 16:06:32 [Preloader] INFO net.runelite.client.rs.ClientLoader - client-patch 1583155852.255

2021-09-13 16:06:36 [AWT-EventQueue-0] INFO net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,538,240,1484x931,layout=java.awt.BorderLayout,title=RuneLite,resizable,normal,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,1484x931,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@11f9b20,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2021-09-13 16:06:58 [Client] ERROR net.runelite.client.RuneLite - Uncaught exception:
java.lang.OutOfMemoryError: null
at java.base/jdk.internal.misc.Unsafe.allocateMemory(Unknown Source)
at java.base/java.nio.DirectByteBuffer.(Unknown Source)
at java.base/java.nio.ByteBuffer.allocateDirect(Unknown Source)
at rs117.hd.GpuFloatBuffer.allocateDirect(GpuFloatBuffer.java:76)
at rs117.hd.GpuFloatBuffer.ensureCapacity(GpuFloatBuffer.java:62)
at rs117.hd.SceneUploader.pushFace(SceneUploader.java:1203)
at rs117.hd.SceneUploader.uploadModel(SceneUploader.java:136)
at rs117.hd.SceneUploader.upload(SceneUploader.java:234)
at rs117.hd.SceneUploader.upload(SceneUploader.java:94)
at rs117.hd.HdPlugin.uploadScene(HdPlugin.java:1983)
at rs117.hd.HdPlugin.invokeOnMainThread(HdPlugin.java:2363)
at rs117.hd.HdPlugin.onGameStateChanged(HdPlugin.java:1972)
at net.runelite.client.eventbus.EventBus$Subscriber.invoke(EventBus.java:70)
at net.runelite.client.eventbus.EventBus.post(EventBus.java:223)
at net.runelite.client.callback.Hooks.post(Hooks.java:169)
at client.yf(client.java:19313)
at cc.ed(cc.java:2053)
at client.i(client.java:1868)
at at.jr(at.java:380)
at at.run(at.java:359)
at java.base/java.lang.Thread.run(Unknown Source)

This is the error that is in client.log every time the plugin is tried to start. windows 7 all drivers up to date (amd 550 rx + i7 3770) Could be just lack of power cause this hardware is definitely "older". Although it entirely depends how the plugin was coded seeing as original hd would have ran smooth on much older hardware. Appreciate all the hard work you've done 117 and continue to do. Hopefully some of these annoying problems are figured out eventually. Thanks guys!

2021-09-13 16:14:01 [Client] ERROR rs117.hd.HdPlugin - Error starting HD plugin java.lang.RuntimeException: rs117.hd.ShaderException: ERROR: 0:120: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:119: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:124: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:123: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:382: 'ssboOffset' : undeclared identifier ERROR: 0:384: 'ssboOffset' : undeclared identifier ERROR: 0:393: 'thisA' : undeclared identifier ERROR: 0:393: 'ssboOffset' : undeclared identifier ERROR: 0:393: '[]' : integer expression required ERROR: 0:393: 'assign' : cannot convert from '4-component vector of int' to 'float' ERROR: 0:394: 'thisB' : undeclared identifier ERROR: 0:394: '[]' : integer expression required ERROR: 0:394: 'assign' : cannot convert from '4-component vector of int' to 'float' ERROR: 0:395: 'thisC' : undeclared identifier ERROR: 0:395 at rs117.hd.HdPlugin.lambda$startUp$0(HdPlugin.java:501) at rs117.hd.HdPlugin.invokeOnMainThread(HdPlugin.java:2363) at rs117.hd.HdPlugin.lambda$startUp$2(HdPlugin.java:440) at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:99) at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:195) at client.tq(client.java:43502) at client.aq(client.java) at at.b(at.java:406) at at.run(at.java:360) at java.base/java.lang.Thread.run(Unknown Source) Caused by: rs117.hd.ShaderException: ERROR: 0:120: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:119: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:124: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:123: '' : shader storage buffer binding must be less than "GL_MAX_SHADER_STORAGE_BUFFER_BINDINGS" (8) ERROR: 0:382: 'ssboOffset' : undeclared identifier ERROR: 0:384: 'ssboOffset' : undeclared identifier ERROR: 0:393: 'thisA' : undeclared identifier ERROR: 0:393: 'ssboOffset' : undeclared identifier ERROR: 0:393: '[]' : integer expression required ERROR: 0:393: 'assign' : cannot convert from '4-component vector of int' to 'float' ERROR: 0:394: 'thisB' : undeclared identifier ERROR: 0:394: '[]' : integer expression required ERROR: 0:394: 'assign' : cannot convert from '4-component vector of int' to 'float' ERROR: 0:395: 'thisC' : undeclared identifier ERROR: 0:395 at rs117.hd.Shader.compile(Shader.java:83) at rs117.hd.HdPlugin.initProgram(HdPlugin.java:669) at rs117.hd.HdPlugin.lambda$startUp$0(HdPlugin.java:497) ... 9 common frames omitted

When setting the fog depth on 0 in "static" and "none" mode the screens has some rendering issues

Plug-in fails once enable option is selected, meaning in does not turn on at all.

When attempted, RL client screen goes black for a few seconds, freezes, and it returns back to normal without the plug-in enabled.

117 HD has been successfully downloaded from plug-in hub, but does not work. Very frustrating.

Environment :

• OS: Windows 10
• RuneLite version: latest

I know nothing about computers but was hyped to use the HD plugin. I have the plugin installed, and when i hover over the bar to turn it on, it says 'Conflicts with GPU'. If i press the bar, it goes orange for about 1 second and freezes the client, then goes back to grey and back to normal with no HD. I understand this same thing was happening to Mac users, but i am on my windows pc. Pretty sure i dont have a graphics card which people told me could be the problem, but if anyone can tell me why i cant use this plugin or what steps i could take to use it, that would be great, thanks.

Not sure if this is possible but similarly to how light sources emit a glow on nearby objects, I am suggesting that the Fire and Infernal cape do the same.

a. when trying to flick prayers, after like 7-10 clicks it bugs and stops flicking correctly. while flicking on quick prayer it works well.
b. w10, gtx 1070, i7-9700kf
c. doing inferno
after i turn of plugin, prayers works well

Describe the bug
I noticed that when you open more and more room in the gauntlet, your fps start to drop more and more especially if you have thoses rooms rendered in front of you (not behind the camera). I don't really have any fps issue anywhere else so I was wondering what is special about the gauntlet room? Well, I found that if you disable/enable the plugin while in the gauntlet, all your fps comes back. So I am guessing there is some sort of issue that happen when you open a new room in the gauntlet.

To Reproduce
Steps to reproduce the behavior:

1. Go to the gauntlet
2. Open rooms, as you open more you will get more fps drop.
3. Disable/enable the plugin
4. All the fps is back. Could this be a memory leak sort of thing? I don't know much about that!

Expected behavior
If I can move around the gauntlet with max settings and full fps after clearing the plugin (disable/enable), there shouldn't be an issue when opening rooms.

Environment (please complete the following information):

• OS: Windows
• RuneLite version: 1.7.24
• Launcher version: 2.0.2

Additional context
Nothing showing on the logs anyway.

After disabling the plugin some areas of the screen render as dead spots. See attached,

vs

Edit: Portal shadow issue in a certain orientation. Only portals placed in this orientation have this weird shadow.

I get an FPS drop when I first enter my house:

If I reset the plugin (off then on again), FPS goes back up:

Platform: Windows 10

i cant get the plug in to work on my acer core i5 laptop. windows 10. Is it just not compatible?

a. When dropping the hydra pet, it has the correct glow to match the current form of the pet, but when using the metamorphosis option to change the form, it retains the previous form's glow
b. Windows pc with an RTX 2080 super using the official RuneLite client
c. I was just checking out some of the lighting effects on pets in the crafting guild
d. its a pretty easy bug to replicate, just use metamorphosis on the hydra pet

dropped the pet in poison form, displays correct glow colour of green:

used metamorphosis to change it to electric form, still displays the green glow from the previous form:

I dont know if intentional, but you cant really see the ground teleporters when they light up

I happened to drop cooked shark on the floor and it has no colours. Looks like raw one. Tried with others items too that i had on but this happens only with shark as far as i know. No issues with that one on overworld.

The allotement patches retain a small portion of the original surrounding rocks colors, the rest of the borders are green.

I did everything but when i hit the switch to turn on the plugin, it just switches off again after freezing briefly

a. Some textures are replaced with snow looking texture while using hd plugin(see attached file)
b. Ryzen 2700x, GTX1070TI (Driver 466.77), 16GB RAM, WIN 10
c. Nothing special
d. I think this happens all the time (no specific steps needed to reproduce)
e. I do not have access to /user/ folder, sorry :/

EDIT: Same thing happening in Edgeville dungeon as shown in issue #23

In the Falador mines, the walls behind the torches are untextured. See attached screenshot.

OS: Linux 5.11.0-34-generic
RuneLite version: 1.7.24
Oldschool revision: Rev 199
Launcher version: 2.1.5

GPU Info

09:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Ellesmere [Radeon RX 470/480/570/570X/580/580X/590] (rev e7)
	Subsystem: Micro-Star International Co., Ltd. [MSI] Radeon RX 580 Armor 4G OC
	Kernel driver in use: amdgpu
	Kernel modules: amdgpu

client.log

2021-09-13 12:06:48 [Client] ERROR rs117.hd.HdPlugin - Error starting HD plugin
java.lang.RuntimeException: rs117.hd.ShaderException: error: Too many compute shader storage blocks (10/8)

	at rs117.hd.HdPlugin.lambda$startUp$0(HdPlugin.java:501)
	at rs117.hd.HdPlugin.invokeOnMainThread(HdPlugin.java:2363)
	at rs117.hd.HdPlugin.lambda$startUp$2(HdPlugin.java:440)
	at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:99)
	at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:195)
	at client.tq(client.java:43502)
	at client.aq(client.java)
	at at.b(at.java:406)
	at at.run(at.java:360)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: rs117.hd.ShaderException: error: Too many compute shader storage blocks (10/8)

	at rs117.hd.Shader.compile(Shader.java:94)
	at rs117.hd.HdPlugin.initProgram(HdPlugin.java:669)
	at rs117.hd.HdPlugin.lambda$startUp$0(HdPlugin.java:497)
	... 9 common frames omitted

Every time I attempt to turn on this plugin, it turns off by itself within a second or two. I see a black flashing screen and then it returns to the normal graphics of OSRS. Im using a MacBook Air running macOS Big Sir. Is this possibly a mac related issue?

Trying to enable the HD plugin currently fails on my 2017 MacBook Pro w/ Radeon Pro 560 and macOS 11.5.2.

Expected behavior: Clicking the toggle switch results in the toggle staying on and HD graphics being enabled.

Observed behavior: Clicking the toggle switch toggles the switch to on, the game freezes for a moment, and the toggle then turns itself back off, with no change in graphics.

If it would be useful, please let me know what the best way to collect the log messages from the failure would be. Thank you for all your work on this plugin, the results are very exciting, and I understand that shipping a plugin for multiple platforms at once is a large undertaking, especially when you don't have access to hardware to test on.

A guess as to a potential cause

OpenCL support was needed to get the GPU Plugin running on Mac due to the plugin's use of compute shaders that are not supported by Apple's outdated version of OpenGL (runelite/runelite#6482). I wonder if OpenCL support as mentioned in #1 might similarly help here, as I see some references to compute shaders in the HD plugin (https://github.com/RS117/RLHD/search?q=compute).