rrthomas / crop Goto Github PK

crop.sty uses in various places \stockwidth and \stockheight to set the mediabox. It sets it to paperwidth/paperheight at the begin, but only if the dimen don't exist:

\expandafter\ifx\csname stockwidth\endcsname\relax
    \newdimen\stockwidth
    \stockwidth\paperwidth
\fi
\expandafter\ifx\csname stockheight\endcsname\relax
    \newdimen\stockheight
    \stockheight\paperheight
\fi

This fails in a current LaTeX 2022-11-01 as the kernel now defines \stockwidth and \stockheight too. As can be seen in this example

\documentclass[10pt]{book}
\usepackage[center]{crop}


\begin{document}
abc
\end{document}

which produce a wrong mediabox:

I suggest to change the test and test for invalid values of the dimen too:

\ifcsname stockwidth\endcsname
   \ifdim\stockwidth > 0pt 
   \else
    \stockwidth\paperwidth
   \fi 
\else
    \newdimen\stockwidth
    \stockwidth\paperwidth
\fi
\ifcsname stockheight\endcsname
   \ifdim\stockheight > 0pt 
   \else
    \stockheight\paperheight
   \fi     
\else
     \newdimen\stockheight
    \stockheight\paperheight
\fi

\documentclass{article}
\usepackage[mirror]{crop}
\begin{document}
Some text
\end{document}

If compiled with pdflatex gives the warning

        Misplaced \pdfrestore by (40258437sp, 0sp)

with lualatex one gets

       warning  (pdf backend): misplaced 'restore' by (40258437sp, 0sp)

The problem is that \rlap is robust since texlive 2018, but the reflection code is executed in a place where \protect has the meaning \noexpand and so it doesn't expand. The following seems to correct the problem:

\documentclass{article}
\usepackage[mirror]{crop}
\makeatletter
\renewcommand*\CROP@genreflect[1]{%
    \leavevmode
    \dimen0\CROP@horigin
    \kern2\dimen0
    \begingroup \set@typeset@protect %change protect
    \reflectbox{%
        \hb@xt@\paperwidth{%
            \vbox to\paperheight{%
                #1%
                \vss
            }%
            \hss
        }%
    }%
   \endgroup
}
\makeatother
\begin{document}
Some text
\end{document}

We just released a new development version of the next LaTeX version,
In this dev release we implemented a new hook system and extended the existing set of hooks.

Details can be found in the announcement:
https://www.latex-project.org/news/2020/07/22/latex-dev-2020-10-1b/

Beside other we implemented a number of shipout hooks which were previously provided by various external packages.

As crop is redefining \shipout it is possible that it clashes with this new implementation, so it would be nice if you could test and (if possible) change the code to use the provided hooks instead. In case you have questions, comments or problems, open please an issue at the LaTeX 2e github.

Ulrike Fischer, LaTeX team