rpiambulance / website Goto Github PK

Currently, this line reads the system time (set for UTC, not Eastern Time):

I believe that adding date_default_timezone_set('America/New_York'); to the top of the file will fix all date/time timezone issues (if there are any others).

The captcha is unusable on multiple pages, and is giving the error:
ERROR for site owner:
Invalid domain for site key

If you look in the console after submitting changes to edit a member there are tons of angular date format errors. These probably are also a part of our dating issues.

When signing up for an overnight crew spot, the margin for that row changes due to the formatting of the "X" button.

See this photo. I'm not sure if it's on mobile only or both...

For our calendar if you scroll to a specific month and click an event once you click back then you will be forced to return to the current month. It should save what month you were on before clicking the event.

Per @MasterOdin:

This only prevents the button from showing up to sign up for a crew, but there's nothing stopping someone from still just hitting the API directly and signing up, but that's also because there's absolutely no checks being done. An issue should probably be made about that.

It appears as though the submit button on "My Settings" page does not work/save changes.

Currently scheduling coordinator has to memorize the hyperlinks needed to modify the schedule and edit the default schedule. These options are prevalent under the admin navigation bar menu and therefore should exist under a specific navigation menu for them.

There is one for facebook, need one for new instagram
https://www.instagram.com/rpiambulance/

The new changes to the way night crew's allowing going backwards or forward seems to have caused a regression with Modify Schedule.

When a user is marked as inactive it doesn't allow them to log in, but it doesn't give them a message and therefore they have no idea what is going on. It should at least say contact [email protected] you have been marked inactive.

If you are just browsing on the website and click the home tab, when you click back to members you will have been logged out and have to log back in.

The PHP session appears to be getting destroyed prematurely causing the user to get logged out even though they haven't been inactive for five days.

Should bring back to previous view, not to current date.

If you submit a game/event form that has errors, there is no indication of that error and it just looks like the form is doing nothing.

These lines:
https://github.com/rpiambulance/website/blob/master/js/controllers/AddEventCtrl.js#L146-L149
https://github.com/rpiambulance/website/blob/master/js/controllers/AddEventCtrl.js#L174-L175

seem to not be doing what they're supposed to.

Member list mailto links for general membership section not filling in correctly. Upper tables work.

When changing one's password, the system shows a message about the passwords not matching, even though they do.

The SOG dropdown is currently named "SOP", which should be changed to reflect NYS guidelines

There seems to be a javascript issue when moving to the expiration page.

TypeError: Cannot read property 'concat' of undefined

It is probably one of the most requested features I get from people familiar with the old version of this site. It would be nice if the website could sync with google calendar so that people could see how their schedule fits in with our events.

Well, make it more normal...

The upgrade to PHP 7.2 caused the edit member page to no longer list the members correctly and nothing is listed there anymore. The edit member page is an extremely helpful tool which we use on a daily basis. This should be fixed ASAP.

For the homepage carousel, the actual spot to click for the 5939 "Read More" is above the actual button.

If I create a new member, their birthday will be off by one. I use 3/15/1999 and the new members birthday was 3/14/1999. Also, angular composing about the date format in the console.

I forget if @David-Sparky said that the button is broken or was never built.

If a user is an admin on the site and you go to the edit member page, unticking the Is Admin box and hitting submit does not actually do anything.

If you were to edit a member and make them a driver lets say, to take that away you have to check, uncheck, check, uncheck. One simple uncheck doesn't seem to work and allows the user to keep their position. This has caused confusion with many people using this feature.

For all members, it would show user's name and email. For CC type users, it would display phone number. This would replace the mailto links that currently exist on those pages.

This should also apply to the events/game pages.

Any action done on the night crew page, such ass viewing last weeks schedule, signing up, or dropping a shift causes the highlighted day to go away as the crew is re-rendered

Currently the website only shows events for which signups are disabled. Would like to have a separate toggle switch on create events page to have front facing events while still allowing for sign ups.

This has been discussed rather extensively in the RPI Ambulance Slack #dev channel, so I'm going to refrain from adding anymore information here.

Require person be 18 to sign up for night crew. Allow for sign up for games/events but with a different name style on event page.

Also would help including example .db_config.php and .admin_config.php` files as well as .sql file containing site schema so someone doesn't need to reverse engineer what's in them if they wanted to develop the site locally to contribute patches.

Additionally, this would be useful in knowing the exact versions of PHP, MySQL, Apache/Nginx configuration, etc. as the README.md's instructions are out-of-date.

mail() has been disabled due to many security issues with it so now PHPMailer with authentication must be used. I think we should implement in a way that calling a simple function will allow us to send email pretty much like normal so that we can re-enable a lot of the forms which we disabled when mail() stopped being supported.

The navbar that is specific for signed in users still appears and everything works after the user click log out, which leads me to believe that logging out doesn't work correctly.

Shows no upcoming events.

session_start pre 7.0 didn't accept any parameters and post 7.0 accepts an array to override session INI directives. It looks like the code is trying to set the session ID to use if psased one via the $_GET superglobal ($_GET['session_id']), which you'd accomplish via the session_id function instead which does accept a parameter that allows you to set an ID to use (so long as you call it before session_start).

You would therefore most likely want to change all instances of:

session_start($_GET['session_id']);

to be:

session_id($_GET['session_id']);
session_start();

The same thing applies for the places that use the $_POST superglobal as well.

See screenshot for overlap

Currently highlighting is based on when the date changes. According to @ddbruce it should be based on which crew is staffing the ambulance. Maybe highlight no crew in between shifts?

We need form validation for the edit member page as people are submitting forms without password or dobs and it causes them to not appear in the edit member pages. This needs to be fixed ASAP as it makes it hard to get many new members emails. This also applied to Add Member!

It has been brought to my attention that the scheduling coordinator doesn't get access to a special menu with links to modify schedule and edit default schedule, instead they're required to manually type in the urls to gain access.

Right now, the check is only done for showing or not showing the button, but doesn't stop someone from just sending a direct request to the API to bypass the button to sign up for any position regardless of eligibility.

SOPs currently define Active, Inactive and Admin. Suggest adding Admin and "archive" status to align with SOPs.

Active, Inactive are permitted to sign up for everything. Admin for only civil side events. "Archive" is for previous members no longer participating in the organization.