rowasjo / fileutils Goto Github PK

Sync file is currently implemented using the low-level Win32 API. Is this the best approach? Alternatively we could have used the Visual Studio CRT library, which would look something like (not tested):

FILE* fd = fopen(file.string().c_str(), "r");
if (!fd) {
  std::string msg = "Got empty file descriptor when attempting to sync file path [" + file.string() + "]";
  throw std::runtime_error{msg};
}

_commit(_fileno(fd));
fclose(fd);

The drawback here is that this only applies for the Visual Studio compiler. MinGW has a different API.