Code Monkey home page Code Monkey logo

netflix4r's People

Contributors

davejachimiak avatar estolfo avatar johncolvin avatar pzupan avatar rossnelson avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

pzupan fasterthanlime tilo davejachimiak lstone ndelage irio johncolvin shrikantpatnaik cliftonclassroom

netflix4r's Issues

Hash rocket to 1.9 syntax

Ross - how would you feel if I changed the hash rockets in netflix4r to 1.9 syntax? Looks like the 1.9 syntax is becoming standard, e.g. Rails 4 will have it as default in generated code and the core is changing hash rockets as they touch code.

Would be my pleasure to make the change and it will clean the code up a bit.

netflix log file is in incorrect location

the location of the netflix API log file is inside the gem directory - that's not a good idea.

This should be configurable. For Rails the default location should be in './log/netflix_api.log'

incorrect config file location

the latest version of

https://github.com/rossnelson/netflix4r/blob/master/lib/net_flix/credentials.rb

says that the config file is taken from

CONFIG_FILENAME = File.join( File.expand_path('config'), 'credentials.yml')

but the version which is used in netflix4r 0.0.2 is using an incorrect location inside the gem folder:

CONFIG_FILENAME = File.join( File.dirname(__FILE__), '..', '..', 'credentials.yml')    # INCORRECT

Looks like this was fixed in the Git Repository, but no new version of the Gem was created?

Could you please fix this, and perhaps also rename the config file to "netflix_credentials.yml" , so there is no name collision if people have more than one credentials file in their project

Bad URI when searching using terms with spaces 

list = NetFlix::Title.search(term: 'Knight', max_results: 1)
 => [Knight Knight] 
list = NetFlix::Title.search(term: 'Dark Knight', max_results: 1)
URI::InvalidURIError: bad URI(is not URI?): http://api.netflix.com/catalog/titles?max_results=1&oauth_consumer_key=MY_CONSUMER_KEY&oauth_nonce=39470&oauth_signature=MY_SIGNATURE&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1347760105&oauth_version=1.0&term=Dark Knight
    from /Users/irio/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/uri/common.rb:176:in `split'
    from /Users/irio/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/uri/common.rb:211:in `parse'
    from /Users/irio/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/uri/common.rb:747:in `parse'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/netflix4r-0.1.0/lib/net_flix/request.rb:25:in `target'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/netflix4r-0.1.0/lib/net_flix/request.rb:29:in `log'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/netflix4r-0.1.0/lib/net_flix/request.rb:34:in `send'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/netflix4r-0.1.0/lib/net_flix/api/catalog/titles.rb:10:in `search'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/netflix4r-0.1.0/lib/net_flix/title.rb:32:in `search'
    from (irb):4
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/railties-3.2.8/lib/rails/commands/console.rb:47:in `start'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/railties-3.2.8/lib/rails/commands/console.rb:8:in `start'
    from /Users/irio/.rvm/gems/ruby-1.9.3-p194@global/gems/railties-3.2.8/lib/rails/commands.rb:41:in `<top (required)>'
    from script/rails:6:in `require'
    from script/rails:6:in `<main>'

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.