rosen-group / ngx-onboarding Goto Github PK

ERROR in : Unexpected value 'undefined' declared by the module 'OnboardingModule in /node_modules/@rosen-group/ngx-onboarding/rosen-group-ngx-onboarding.d.ts'

Add installation of peer dependencies to readme

The exception is raised when using SSR. is it possible to add the condition of
if (isPlatformBrowser(this.platformId)) {
//use localStorage
}

Thanks!

Diego

in v1.8.0

CONTRIBUTING.md

• Missing u in reqest in If you want to contribute send us a pull reqest.

I18N.md

• Should be probably Then instead of Than in Than you have to provide the key value pairs for the translations

• Typo: minimum instead of minimium in the argument has the minimium properties. Or even better: the EventEmitter argument has one required property lang: string

I want to hide the onboarding button if no items are registered

The 'Got it' and 'Turn off' buttons should be positionable.
Reason: if you want to show an onboarding item for an element in the down right corner the buttons conflict with the onboarding element.

When I use the spotlight on one of my elements, the element becomes invisible (the whole spotlight is just plain white).

With onboarding closed:

After adding this to styles, everything works as expected for me:
.onboarding-spotlight { background: transparent !important; }

https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/

Update to Angular version 12.
Step to archieve the task can be found here

Sample App E2E Test is broken:

1. workspace-project App should show onboarding overlay initially and hide it if "Turn Off" button is clicked

• Failed: Wait timed out after 10009ms

(...)
          at AppPage.waitAndCountOnboardingHeader (/home/steffen/git/github/ngx-onboarding/e2e/src/app.po.ts:25:17)
          at UserContext.<anonymous> (/home/steffen/git/github/ngx-onboarding/e2e/src/app.e2e-spec.ts:23:21)
(...)

Update dependencies in lock file

In a DevExreme modal dialog the onboarding item appears on a wrong position.

The problem is that in the popup window the controls selected to be explained are shown dark and not light like in the rest of the window.

We just updated to Angular 9 RC and get the following error when compiling our solution (works fine on Angular8):

chunk {mainERROR in Failed to compile entry-point @rosen-group/ngx-onboarding due to compilation errors:
} main.js, main.js.map (main) 2.06 kB [initial]node_modules/@rosen-group/ngx-onboarding/fesm5/rosen-group-ngx-onboarding.js(2047,30): error TS-991010: Value at position 1 in the NgModule.imports of OnboardingModule is not a reference: [object Object]
 [rendered]

Are there any plans to update to Angular 9? Would be very happy :)

Setup CI/CD workflow:

• build & tests for PR
• CI build & tests
• deploy package on npm
• optional: run e2e tests

I wanted to ask if there was a specific reason to use lodash-es in the project? It uses the following utilities (search result), which either have native equivalents, or easy replacements:

• each (actually forEach) - Array#forEach can be used
• filter - Array#filter can be used
• find - Array#find can be used
• some - Array#some can be used
• isEmpty - no native method, but where being used, simple falsy checks might be good enough
  • Usage 1 - seems to be checking if a string is empty
  • Usage 2 - checking result of Storage.getItem, which will either be a string or null

I'm getting an dependency error when attempting to install this package.

I'm running angular 15+

npm ERR! Found: [email protected]
npm ERR! node_modules/rxjs
npm ERR!   rxjs@"^7.8.0" from the root project
npm ERR!   peer rxjs@"^6.5.3 || ^7.4.0" from @angular/[email protected]
npm ERR!   node_modules/@angular/core
npm ERR!     @angular/core@"^15.1.0" from the root project
npm ERR!     peer @angular/core@"^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0" from @rosen-group/[email protected]
npm ERR!     node_modules/@rosen-group/ngx-onboarding
npm ERR!       @rosen-group/ngx-onboarding@"*" from the root project
npm ERR!     7 more (@angular/animations, @angular/cdk, @angular/common, ...)
npm ERR!   4 more (@angular/cdk, @angular/common, @angular/forms, @angular/material)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rxjs@"^6.5.4" from @rosen-group/[email protected]
npm ERR! node_modules/@rosen-group/ngx-onboarding
npm ERR!   @rosen-group/ngx-onboarding@"*" from the root project

Will it work with angular 5?

save methods are never subscribed

Try to add a picture
doesnt work...
using external link e2e test report

It doesn't work with the following material components: Tabs, Sidenav.

All elements inside these componentes won't be properly highlighted. They get completely covered instead of just being highlighted.

The following image shows the issue.

TsLint is deprecated in ng-cli -> move to eslint

Solution needs to be updated to angular 13

Just ran the the npm lint job and this is what showed up:

ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[32, 44]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[47, 28]: variable 'getHtmlElements' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[50, 46]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[64, 55]: variable 'getOnboardingItems' used before declaration
ERROR: ngx-onboarding/projects/ngx-onboarding/src/lib/services/onboarding.service.spec.ts[130, 40]: variable 'getOnboardingItems' used before declaration

We should adjust the tslint rules or push the constant to the top of the spec file...
Anyway, @SDohle why is our pull request build not running the lint job?

in Angular 9 : ERROR in The target entry-point "@rosen-group/ngx-onboarding" has missing dependencies:

• lodash-es
  

i am using "@rosen-group/ngx-onboarding": "^1.7.0", in package.json and using import statements like this
import {OnboardingItem, OnboardingService} from '@rosen-group/ngx-onboarding';

so what i am missing ?

The usage of matBadgeDisabled breaks ng6 support

Documentation has to be written for the configuration options of text, icons and button positioning