`on_shutdown` callback not called when `shutdown` transition is triggered on dtor about rclcpp HOT 2 CLOSED

I believe both tests fail because during object destruction in C++, the derived class dtor is called first, followed by the base class dtor. At this point, the virtual table (vtable) is already updated to reflect the base class, meaning any virtual method calls within the base class destructor will not invoke the overridden methods in the derived class.

Consequently, when rclcpp::LifecycleNode dtor calls shutdown() and triggers the transition, if there is a subclass-defined registration of a non-virtual method (although it can lead to undesired behavior as shown in #2553) the appropriate derived class method is called while any call to a virtual method (such as on_shutdown) will call the base class implementation.

from rclcpp.

see #2520 (comment), all related to PRs are rolled back and merged.

i will go ahead to close this issue, feel free to reopen if i miss anything.

from rclcpp.