Image Projection Model about common_interfaces HOT 2 OPEN

In theory, you can pack whatever distortion model you want between the string field and the distortion parameters. It's not clear to me why that wouldn't be sufficient here?

from common_interfaces.

Well, yes I can put what ever information into the distortion model string, sure.
But I would consider the distortion model describing lens distortions as something else than the projection model used during rectification.

Maybe a specific example might help here:

I implemented different distortion models for different kind of lenses and different approaches used for calibration
For this example this could be:

1. plumb_bob
2. fisheye_opencv
3. fisheye_matlab

now I put the respective name into the distortion model field.
Further I have different distortion parameter for all of these approaches and put them into the respective array.

For each of the undistortion approaches I can now decide whether the undistorted image should be created using a pinhole projection, a spherical projection, or a cylindrical projection.
The projection model used is independent of the distortion model used to describe the lense distortion.

When I add the information of the projection model to the distortion_model field I would end up having 9 different configurations/names.
Possible yes, however, I would prefer both information in a separate field (e.g., a string or enum).

from common_interfaces.