ropensci-archive / getlandsat Goto Github PK

https://github.com/sat-utils/sat-api

want to make sure outputs are useful

Tried the readme, and got this

> x <- lsat_search(collection = "landsat-8", cloud_cover = c(0, 20), limit = 3)$features
> 
> x
NULL
> names(x)
NULL

API problems?

I was working on some of my own stuff, and got the following

> recs <- lsat_search(collection = "landsat-8", row = 30, path = 12)
> recs
$links
                                             href     rel
1             https://sat-api.developmentseed.org    self
2 https://sat-api.developmentseed.org/collections    data
3             http://sat-utils.github.io/sat-api/ service

So, better? But, something isn't connecting here.

See https://docs.ropensci.org/getlandsat/ and this comment from Hadley: ropensci-org/rotemplate#19 (comment)

You can also have a look where other packages store readme.md figures:

• https://github.com/ropensci/tidyhydat/
• https://github.com/ropensci/drake/

Also the vignette is missing a title: https://docs.ropensci.org/getlandsat/articles/

I noticed that the projection of the scenes downloaded by the package is WGS84 - to check, these are reprojected scenes, yes? As the originals I've gotten from NASA/USGS in the past are in UTM, not stere as put up here. Have the scenes to download been reprojected?

from #3

Not that I can find so far...

Just a thought, if subsequent calls to lsat_image for the same file used a locally cached version instead of re-downloading.

Low priority.

should they be treated in any special way?

from review:

talk a little bit in the vignette about what the list_scenes and list_scene_files functions are doing and what they return

If, e.g. download process stopped, remove file as can't really use a partial file

from #3

Hi,

Is it within the scope of the package to build a function to discover scenes that are matching a given spatial extent?

Use case: I have the bounding box of my region of interest, and I am wanting to list all the Landsat scenes available over that bounding box.

Cheers,

or perhaps safer to do so in new function

https://sat-utils.github.io/sat-api/

• search path changed
• looks like we need to use the POST method instead of GET now