• Enhance documentation for R.swift and Router
• Explain what/how/when to use both

Useful if the user logs out or deletes the account.

ThirdPartyKeys.example.plist file is being bundled during the Copy Bundle Resources phase

Currently, the APIClient class tries to parse a dictionary using JSONSerialization, this brings a couple of problems:

1. single elements or Arrays from a JSON response are not be supported.
2. The dictionary is then used to convert it into a Data object to then use a JSONDecoder. This is an unnecessary back and forth which adds complexity and more prone to errors.

Ideally, the client would pass a type that would like to get back and the APIClient will handle the rest. An alternativeis to ahve like a middle layer that takes care of the parsing/decoding.

The services variable type should be [AnalyticsService] so the declaration should be changed to:

open var services: [AnalyticsService] = [FirebaseAnalyticsService()]

Once the devise token expires in the backend, the ios app should be automatically logged out.

Right now when the token expires, the app gets stuck as the session doesn't close and the user is not able to do any action (including logout)

rootstrap/rails_api_base#44 removes the me routes for just user/, check the apiary.apib file for the api changes.

Needs this done before merge the api base merged

Replace Demo Facebook integration with Apple Sign in.

With the current implementation, every request will end up calling the onSuccess callback. We should filter the success codes to handle the response correctly.

I am pretty new to RxSwift and I am using the code from the branch mvvm+rxSwift, which has the following function for a request of given ProviderType -

    open func request<T>(for target: ProviderType,
                         at keyPath: String? = nil
                         ) -> Observable<(T, Response)> where T: Codable {
        return provider.rx.request(target)
        .filterSuccessfulStatusCodes()
        .flatMap { [weak self] response in
          let decodedValue = try response.map(T.self,
                                              atKeyPath: keyPath,
                                              using: self?.jsonDecoder ?? JSONDecoder(),
                                              failsOnEmptyData: true)
          return .just((decodedValue, response))
        }
        .asObservable()
        .catchError { [weak self] error in
          guard let self = self else {
            return Observable.error(error)
          }
          return Observable.error(self.handleError(with: error))
        }
    }

This works pretty well, but now I want to retry the request when the request fails with a status code of 401, after fetching the refresh token. I found this comment on a GitHub issue which tells how it can be achieved but I am still confused how it will work in my case (the comment does not provide context related to how the refresh token mechanism works).

Rails 5 API is no longer using the method to update the session headers in every request.
Remove this feature from the swift-base saving the session only in sign up and sing in.

When the login fails (user or password are not ok) the server answer is 401.
In the CommunicationManager if the answer is 401, then the app logs out the user, so the login screen is dismissed and the user go back to the landing screen. Then the error message appears in the landing screen instad of the login screen.

Use rails example for reference.

Include extra branches in documentation.

This guide is very helpful. Thanks to @MaicolBen 😀
Open source recommendations:

• Licence
• Readme contents: Description, Features/Contents, Getting started, How to use it, Rootstrap Credits
• Changelog and versioning
• Blocked main branch for force push
• CI and code quality configured (with badges)

Part of Milestone #1

A first set of changes need to be implemented in order to start using MVVM. This will include:

• Refactor current examples(Sign In, Sign up, etc).
• Possible changes in the networking services classes.

Next, a FlowManager/Router, Services Providers, Validators can be implemented to complete the goal.

On Communication Manager, line 258 the responseDictionary returns the following error:
return .failure(NSError(domain: "Check your connection", code: 0, userInfo: nil))

On TopPlay we realized that this actually prevents the correct error code to be returned.
This line should be:
.failure(error!)

• Ideal: we should have translator comments in the Base language file, as all others should be generated by translators.
• Better: Have an automatic way to generate Base.strings file from original localizations file(say .yml, .json, etc)

Modify the operation handleError in the CommunicationManager so as to support the case that the API throws an error :base, actually the API doesn't take into account this case, it assumes that the error is always in a specific entity field.

To get further information about the error base take a look at:

http://stackoverflow.com/questions/706533/ruby-on-rails-errors-add-to-base-vs-errors-add

PhaseScriptExecution R.swift

..../AwesomeProject/Build/Intermediates.noindex/AwesomeProject.build/Debug-iphonesimulator/AwesomeProject.build/Script-FE06840022CE7D8300C6294F.sh: line 3: /R.swift/rswift: No such file or directory
Command PhaseScriptExecution failed with a nonzero exit code

Xcode 11 beta 5

When using .modal option on navigation router, add support for .fullscreen besides the default modal on iOS13

The current version of the Facebook SDK is using UIWebView which is deprecated and not accepted any longer in iTunesConnect/AppStore sumbissions.

The testAccountCreation test fails randomly.

Some failure examples:

1:

testAccountCreation, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Expect predicate `exists == 1` for object "GetMyProfileButton" Button".

2:

testAccountCreation, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Expect predicate `exists == 1` for object "GetMyProfileButton" Button".
  XCTestCaseExtension.swift:16

  testAccountCreation, Failed to get matching snapshot: No matches found for Elements matching predicate '"GetMyProfileButton" IN identifiers' from input {(

Test integration with Slack

• Update iOS minimum version to iOS 11.

IMO App navigation and routing should be in the View part of MVVM, not in the ViewModel.

Two different views might want to continue to different screens after the same View Model does something.

Do network stubbing in order to run the tests faster and avoid false negatives.

Key APIs and DSLs should be documented properly.
The recommendation is to use Apple docstrings.
In the near future(Xcode 13 and later) we could be able to switch to DocC

Create a new branch for Swift 4.0+ support.

We can keep Storyboards in a separate branch to keep offering that choice

It should be fixed in

The api base is changing that in rootstrap/rails_api_base#107

Add extension to instantiate controllers using generics

extension UIStoryboard {

    public class func instantiateViewController <T: UIViewController>(_ type: T.Type, storyboardIdentifier: String = "Main") -> T? {
        let storyboard = UIStoryboard(name: storyboardIdentifier, bundle: nil)
        return storyboard.instantiateViewController(type)
    }

    public func instantiateViewController <T: UIViewController>(_ type: T.Type) -> T? {
        return instantiateViewController(withIdentifier: String(describing: type)) as? T
    }
}

https://codeclimate.com/changelog/1522435715584/

Possible solutions:

• Implement home made loading indicator/spinner
• Leave without loading indicator and let devs to decide when a new project starts
• Add an existing solution(pod) to the base :(

In the decode method (required init(coder aDecoder: NSCoder)) of the user model, the following line should be: self.id = aDecoder.decodeInteger(forKey: "user-id") instead of self.id = aDecoder.decodeObject(forKey: "user-id")

At least in the README so users and maintainers can easily test the functionality

I think we could rename the CommunicationManager for something more shorter like APIManager

synchronize() is no longer needed for the correct store of the values and also could bring performance issues. Please remove the synchronize()

Now it will be needed after rootstrap/rails_api_base#46 is merged

Usually apps tend to have multiple schemes/build configurations, like Ad-Hoc, Debug and Production.
The current project uses the same bundle ID, so the app would rewrite itself after every installation/run.
It would be nice to have the ability to install several versions of the app based on the existing schemes/build configurations.

Remove all compiler warnings from all targets.

Remove: @mcousillas6 @smanini1

Add: @kstoletniy @fpiruzi @LetoFranco @LeandroHiga @FLTravieso @danialepaco @agerace

We have had issues with Xcode not showing warnings depending on the installation method, adding it as a dependency may solve this issues.

Make ComunicationManager support base64 encoding for images only.
Note: DO NOT delete the current multipart implementation, the swift-base must allow the user to decide the encoding to every Media.

At some point, any app may need force update to run correctly. It's nice to have this from day 1 implemented just in case. Maybe as a separated branch as an optional feature but I think would be nice to have it.

While using tokens from device_token_auth for session management, implement feature to invalidate the current session if error code 401 is returned in any request.
That way, when the token expires the user is not longer stuck with an invalid session.

Fix CI/CD tests and coverage report.

Great repo 😄!! Attempted to push a branch and PR but got 'denied access' 🤕. would love to contribute! Took me a while to figure out why my server wasn't processing the request correctly but found out that patch wasn't using JSON encoding at default 😉

one liner in my attempted PR:

class func defaultEncoding(forMethod method: HTTPMethod) -> ParameterEncoding {
    switch method {
    case .post, .put:
      return JSONEncoding.default
    default:
      return URLEncoding.default
    }
  }

to

class func defaultEncoding(forMethod method: HTTPMethod) -> ParameterEncoding {
    switch method {
    case .post, .put, .patch:
      return JSONEncoding.default
    default:
      return URLEncoding.default
    }
  }

Update replace root transition type to a more native transition.