roonlabs / node-roon-api-volume-control Goto Github PK
View Code? Open in Web Editor NEWLicense: Apache License 2.0
License: Apache License 2.0
node-roon-api-volume-control/lib.js
Line 42 in 87b6885
When destroy is called the local callback is not removed correctly. The key used here should be
delete(this._objs[o.state.control_key]);
Issue #3 is related to this as well.
I want to implement a volume control for a device which supports only volumeUp / Down.
I guess volume_type is the place where I can define it. As there is no documentation I was searching in samples and found only 'number' or 'db".
How can I implement a volume control with "volumeUp" and "volumeDown" ?
As mentioned in #2 there is another issue with registering of new controls.
Apparently the roon server does not accept a second call to "new_device"
node-roon-api-volume-control/lib.js
Line 35 in 87b6885
The first time it is called it succeeds. If you then destroy this subscription and call new_device again the new control is not registered. Together with #2 this results to the following.
node-roon-api-volume-control/lib.js
Line 41 in 87b6885
does not work since it should be (at least I think)
this._svc.send_continue_all('subscribe_controls', "Changed", { controls_removed: [ o.state.control_key ] });
If changed like this roon server successfully de-registers the control
I tried this for testing with a simplified version of the meridian extension.
Reproducing is quite simple, just modify the configuration which then results in a new setup call.
Hi,
Function 'set_mute' is not working with the latest version of Roon 1.4 (306).
The 'req' object now contains the 'on'/'off' value for mute in req.body.mode, but the function written here is trying to access it under req.body.action.
Fix can be done in two ways:
1/ fix Roon to pass the value in req.body.action
Then no update is needed on this function
2/ update the 'set_mute' function to use req.body.mode
Thanks,
Stefan
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.