roonlabs / node-roon-api-volume-control Goto Github PK

Hi,

Function 'set_mute' is not working with the latest version of Roon 1.4 (306).
The 'req' object now contains the 'on'/'off' value for mute in req.body.mode, but the function written here is trying to access it under req.body.action.

Fix can be done in two ways:
1/ fix Roon to pass the value in req.body.action
Then no update is needed on this function
2/ update the 'set_mute' function to use req.body.mode

Thanks,
Stefan

When destroy is called the local callback is not removed correctly. The key used here should be

delete(this._objs[o.state.control_key]);

Issue #3 is related to this as well.

As mentioned in #2 there is another issue with registering of new controls.
Apparently the roon server does not accept a second call to "new_device"

The first time it is called it succeeds. If you then destroy this subscription and call new_device again the new control is not registered. Together with #2 this results to the following.

• First time registration works
• calling destroy via
  

  node-roon-api-volume-control/lib.js

  Line 41 in 87b6885

  this._svc.send_continue_all('subscribe_controls', "Changed", { controls_removed: [ o.control_key ] });

does not work since it should be (at least I think)

this._svc.send_continue_all('subscribe_controls', "Changed", { controls_removed: [ o.state.control_key ] });

If changed like this roon server successfully de-registers the control

• Calling new_device again fails (I am not sure why)
  The extension sends the request to the server but it is apparently ignored resulting in no volume control.

I tried this for testing with a simplified version of the meridian extension.

Reproducing is quite simple, just modify the configuration which then results in a new setup call.

I want to implement a volume control for a device which supports only volumeUp / Down.
I guess volume_type is the place where I can define it. As there is no documentation I was searching in samples and found only 'number' or 'db".

How can I implement a volume control with "volumeUp" and "volumeDown" ?