ronwalf / poolesville-2010-games-project Goto Github PK

I don't think the JUnit tests work with "assertEquals" for arrays of primitives. I changed
assertEquals(new double[]{-1.0, 1.0}, TicTacTransition.instance.score( state ));
to
assertTrue(Arrays.equals(new double[]{-1.0, 1.0}, TicTacTransition.instance.score( state )));

and it seems to work for me.

The tests were also failing because of this on the "FinishedGame" tests:
assertEquals(0, moves.size());

I think this is because the "enumerate" method of TicTacTransition enumerates states for all null cells, even if the current state is supposed to be the end of the game. To fix this, I added in
if(score(s) == null)
before the for loop that checks which cells are empty.

Hi if you are still working on the repository I would like to offer some changes in regards of the use of SOLID principles. If its inactive or you are not interested in the input, disregard this message. If not I have attached a word documment file. Might need translation.
Thank you.