romainlt / convert-seconds-to-human Goto Github PK
View Code? Open in Web Editor NEWConvert seconds into Y/D/H/M/S, in calendar and astronomical format
Convert seconds into Y/D/H/M/S, in calendar and astronomical format
Hi,
Thanks for writing up this nifty utility function. I was testing it using a timer/stopwatch and noticed that at exactly 60 minutes (1 hour) the seconds stopped incrementing (stayed at 0). At the 61st minute (at 1:01:00), the seconds resumed to increment. When reviewing your code, I noticed that it's because you have the seconds check inside n nested if
statement where you only update obj.seconds
if(minutes < 60)
. I can open a PR if you want.
Here is the offending code:
if (minutes < 60) {
obj.minutes = minutes
if (restSeconds > 0) {
obj.seconds = restSeconds
}
} else if (minutes === 60) {
obj.hours = 1
obj.minutes = 0
}
As you see above, obj.seconds
is only updated in the case of minutes < 60
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.