rolandoislas / peripheralsplusone Goto Github PK

Description

Minecraft crashes because of duplicated ID: speaker

Steps to Reproduce

1. Start the game

Expected behavior: To normally load

Actual behavior: The game crashed

Stacktrace (if applicable): https://pastebin.com/vMRX0Msa

Version affected: 1.10.2,

Additional Information

Might work removing speakers or change their ID (CC1.80 has its own speaker)

Description

ME bridge give error block is not a valid inventory when export item into storage from other mods

Steps to Reproduce

1. [First step]
   
2. run command in lua api
   me = peripheral.wrap("back")
me.retrive("minecraft:stone",0,2000,"west")
   error : block is not a valid inventory

...
Expected behavior: [What was supposed to happen]
block output to enderchest and return is 2000

Actual behavior: [What actually happened]
block is not a valid inventory

Version affected: [The version of PeripheralsPlusOne (e.g. x.x.x-x.x.x-build-Tx) and Forge]
PeripheralsPlusOne-1.12.2-1.1-build-T58.jar
forge-14.23.2.2654

Additional Information

ME bridge can't export to any chest except vanila chest

Description

When logging in near a Minecolony, the game crashes if PeripheralsPlusOne is installed.

Steps to Reproduce

1. Have a Modpack with only Minecolony
2. Build a colony
3. Add PeripheralsPlusOne
4. Try to join the Server again

Expected behavior:
It should not crash

Actual behavior:
It crashes

Stacktrace (if applicable):
https://hastebin.com/wahafolebi.txt

Version affected:
PeripheralsPlusOne-1.12.2-1.1-build-T58.jar

Additional Information

We are using CC-Tweaked instead of the normal ComputerCraft, but i haven't had issues with CC-Tweaked and PeripheralsPlusOne before.

Description

the mod has been taken down

Steps to Reproduce

1. go on official site.
2. try to download the mod

...

**Expected behavior:**the mod should been downloadable

Actual behavior: the mod cannot be downloaded

Stacktrace (if applicable): [PASTEBIN or HASTEBIN link to the stacktrace. Do NOT copy and paste the log into the issue post itself.]

**Version affected:**all

Additional Information

[Any other information that may be able to help me with the problem]

Description

Chunks are not loaded by the chunky turtle

Steps to Reproduce

1. Place a chunky turtle
2. Have something that will change state if the chunk unloads (e.g. a program looping the os.clock() to chat via command turtle)
3. Leave the chunks loaded by the turtle

...

Expected behavior: Chunks around the turtle should stay loaded

Actual behavior: Chunks unload

Stacktrace (if applicable): N/A

Version affected: v1.12.2-1.1-dev (T37) | Forge 1.12.2-14.23.1.2555

Additional Information

N/A

Description

Enchanting a book with an XP turtle makes the same enchantments after loading and unloading chunks (or something like).
I always get Smite 4 -> Power 3 -> Curse of Vanishing in this order after turtle loading.

Steps to Reproduce

1. Enchant some books with the same level
2. Unload the chunk (i guess)
3. Get back
4. Enchant more book

Expected behavior: Get truly random enchantments

Actual behavior: Get the same enchantment set

Version affected: 1.12.2-1.0.1-build-T58 ; Forge 14.23.5.2854

Additional Information

I think it's all about the "BetterRandom" thing in PeripheralXP.java : the random seed is saved in the turtle PeripheralXP.java#L227 and is reloaded with the turtle PeripheralXP.java#L46.
The easiest solution is regenerate a seed everytime the turtle is loaded. I think it won't be a performance issue.
I'd test it but the project doesn't compile on my side.

Description

The username value in the the chat event is always nil.

Steps to Reproduce

1. Place a chat box and set it up to print all messages
2. Observe that the user argument is nil.

Tested on 1.11.2-1.0-build-T17.

This is due to this line:

It uses EntityPlayer.getDisplayName(), but that returns an ITextComponent which ComputerCraft will convert to null. One should probably call getUnformattedText on that (or use EntityPlayer.getDisplayNameString()).

Description

I would like to be able to access a bee's inactive attributes in the Bee Analyzer.

Currently, the Bee Analyzer is only able to access the values in the left column, and the secondary species (according to the docs, at least)

Steps to Reproduce

N/A

Expected behavior:
Either the results show up in analyze(), or a separate function is added called analyzeInactive() or something like that, which shows the inactive attributes.

Actual behavior:
Covered in the description

Stacktrace (if applicable):
N/A

Version affected:
N/A

Description

The AI chatbox's responses seem random.

Steps to Reproduce

1. Create a new chat session
2. Ask it something

...

Expected behavior: The response should be somewhat relevant

Actual behavior: The response is random

Stacktrace (if applicable): N/A

Version affected: PeripheralsPlusOne-1.12.2-1.1-build-T58, Forge 14.23.1.2555

Additional Information

Description

I'm not sure if exists any way to do it but I'm thinking if it is not possible to shear the tree's leaves. If not, it will be a great new feature for shearing turtle.

Steps to Reproduce

1. Place a shearing turtle or a regular turtle with shears in the selected slot in front of a leaves block.
2. Enter commands: turtle.dig(), turtle.attack(), turtle.suck(), turtle.place()

Expected behavior:
Remove the leaves block in front and add the leaves item in the turtle's inventory.

Actual behavior:
turtle.dig() removes the block but don't add the item in the turtle's inventory.
The other actions do nothing.

Version affected:
Minecraft 1.12.2
Forge 1.12.2-14.23.5.2768
CC: Tweaked 1.12.2-1.85.0
PeripheralsPlusOne 1.12.2-1.1-build-T58

Additional Information

• A regular or shearing turtle with a shears in the selected slot returns true when turtle.place() or turtle.placeDown() is called and this block is occupied by a sheep but wool is not added to the turtle's inventory or the world, the sheep does not lose the wool either.
• Seems that MiscPeripherals got something like that. I've been looking in some forks in GitHub but I have not experience in Minecraft Modding so I'm not sure which part of the code references this issue.

Description

When Drawing Text on Screen with smart helmet even when specifying color color is changed when it is shown against other blocks. For example, the sky seems to change the color to a purplish whereas something like obsidian seems to bring it to its set color.

Steps to Reproduce

1. Write some code to generate text on hud
   Heres what i used:

local hud = peripheral.wrap("top").getHUD("Colink02")
local gui = hud.getGUI()
local width = 600
hud.drawString("Welcome",30,300, hud.getColorFromRGB(161,244,66))
hud.sync()

2. Run
3. Look over some blocks like grass, snow, ice
   ...

Expected behavior: [What was supposed to happen]
Color of text stays consistent through out.

Actual behavior: [What actually happened]
Color of text changes depending on what block or anything is being rendered in the background e.g. Grass Block, or The Sky.

Version affected: [The version of PeripheralsPlusOne (e.g. x.x.x-x.x.x-build-Tx) and Forge]
1.12.2-1.2-build-T71

Additional Information

(Sorry if i am finding alot of bugs :D)

Description

ME Bridges' listItems() returns NoSuchMethodError

Steps to Reproduce

bridge = peripherals.wrap("meBridge_0"); bridge.listItems();
run this code and it does it.

...

Expected behavior: [What was supposed to happen]
Return an array of items

Actual behavior: [What actually happened]
Gives an error

java.lang.NoSuchMethodError:de.ellpeck.actuallyadditions.mod.util.StringUtil.localize(LJava/lang/String;)Ljava/lang/String;

Version affected: [The version of PeripheralsPlusOne (e.g. x.x.x-x.x.x-build-Tx) and Forge]
PeripheralsPlusOne-1.12.2-1.1-build-T58
ForgeMultipart-1.12.2-2.6.1.81-universal

Additional Information

I have actually additions installed on version 1.12.2-r147.

Description

Cant Download the Mod
Link to CurseForge aint working

Steps to Reproduce

click the link

...

Expected behavior:
website should exist...it doesnt

Actual behavior:
yea uh doesnt exist

Stacktrace (if applicable):
what

Version affected:
idk every version i guess?

Additional Information

Uhhhh click the link to curseforge

when i put the mod in my game i can load it but when i go into my world i get this crash report

https://pastebin.com/dt4XCEhU

for what i can see and have told it is the rfid card that is the problem just fyi i am not so good at crash reports so if it is something else i will love to hear it

Description

When I install the mod and its required dependencies, it fails to load any of the items from the mod.
I'm running a slightly modified version of the crackpack with the twitch client.

Steps to Reproduce

1. Install the mod and "the framework" on the crackpack. load a single player world.
2. check NEI

...

Version affected:
1.7.10

Additional Information

Using PeripheralsPlusOne-1.12.2-1.1-build-T58 and Forge 14.23.5.2860

Speaker isn't working, it throws a NoClassDefFoundError in console everytime you try to use the speaker.
I'm using this command in the computer lua:
s = peripheral.wrap("right") s.speak("Hi")

I've also tried using .web, specified the KEY like the wiki says and it doesn't appear to be working. Throws a nil value in the computercraft GUI

Description

The sound from the speaker does not stop if you leave the world until it is complete.

Steps to Reproduce

1. Place speaker and setup (peripheral.wrap(side))
2. doing something like speaker.synthesize("Test",10,"kevin16",5)
3. leave game while still running

...

Expected behavior: [What was supposed to happen]
I would think at the time of logging out it should mute the sound.
Actual behavior: [What actually happened]
It continues until complete
Stacktrace (if applicable): [PASTEBIN or HASTEBIN link to the stacktrace. Do NOT copy and paste the log into the issue post itself.]

Version affected: [The version of PeripheralsPlusOne (e.g. x.x.x-x.x.x-build-Tx) and Forge]
1.12.2-1.2-build-T71

Additional Information

[Any other information that may be able to help me with the problem]
This may only be applicable on a server.

Description

Hey! - The Speaker cannot play a string by a different language! :(

Steps to Reproduce

lua#> chat = peripheral.wrap("top")
lua#> chat.speak("Hallo", 100, "de") -- does not work
lua#> chat.speak("Hallo", 100, "de_DE") -- does not work
lua#> chat.speak("Hallo", 100, "deutsch") -- does not work
lua#> chat.speak("Hallo", 100, "german") -- does not work
lua#> chat.speak("Hallo") -- works but is literally wrong spoken out

Expected behavior: The word "Hallo" said in german language.

Actual behavior: Nothing. Not even a error in console.

Stacktrace (if applicable):
n/a

Version affected:
PeripheralsPlusOne-1.12.2-1.1-build-T58.jar
Forge 14.23.2.2627

Description

When a player logs out and logs back in to a server, the nano bots applied to them no longer function correctly. When calling player.getPlayerName(), the code errors, saying the entity cannot be interacted with. This is reproducible on my server, running a modded FTB Revelations pack.

Some functions work correctly (like getRemainingBots() and isPlayer()) and some do not (like isDead() and getPlayerName())

It appears the main branch has a similar issue

Version affected: PPO-1.12.2-1.0-build-T31, Forge 2601

Description

Having problem with inventory sorter when i try to push same items with different nbt tag into inventory, it treats like the item is stackable. had no idea how to explain it but you can try to reproduce it

Steps to Reproduce

just put several item with different nbt to a chest, pull the second slot with inventory sorter and push it again
...

Expected behavior:
it suppose to be the moved item must be placed in the second slot because it's not stackable

Actual behavior:
The item is stacking, and nbt data of moved item is changed

Version affected:
1.12.2-1.2-build-T63
forge 2705

Additional Information

maybe you can add third parameter for push method so it can pushed to specific slot like pull method (srry for my bad english)

Description

Items are overwritten when pushed to an Inventory. Some inventories don't accept items from pushing, Ex: Applied energistics interfaces or Ender chests(modded). I was only able to push to a chest. Maybe related to #13

Steps to Reproduce

video: https://www.youtube.com/watch?v=YmyHgWHUL-w
code: https://pastebin.com/snne2zgB

Modpack FTB Ultimate Reloaded 1.6.0
Forge: 14.23.5.2836
cc-tweaked-1.12.2-1.82.2
PeripheralsPlusOne-1.12.2-1.1-build-T58

Description

Peripheral Container can not contain peripherals from CC:Tweaked, such as Wireless Modems or Speakers

Steps to Reproduce

1. Take a Peripheral Container and a Modem/Speaker
2. Put in crafting table to combine them

Expected behavior: Peripheral container would show up in the output slot with a wireless modem or speaker

Actual behavior: Peripheral Container does not show up in output slot

Version affected: Tested with PeripheralsPlusOne 1.12.2-1.1-build-T58 and 1.12.2-1.2-build-T71, with Forge 14.23.5.2821 and CC:T 1.12.2-1.81.1

Additional Information

May be related to #9 and may even be a duplicate if I'm reading it incorrectly.

Description

The retrieve() function on the ME Bridge peripheral seems to ignore the metadata passed in to parameter 2. It seems to grab the first item in the network with the same ID, ignoring the metadata. To replicate, perform the function with a network that has multiple items with the same type but different metadata (ie, the materials in thermal).

Could the error be related to this function? (Does IAEItemStack::isSameType return true when metadata is different?)

Version affected: PPO-1.12.2-1.0-build-T31, Forge 2601

Description

I am unable to add a wireless modem to a chunky mining turtle

Steps to Reproduce

1. Create chunky mining turtle
2. add wireless modem to crafting

Description

I am getting "A fatal error has occured, this connection is terminated" on a server while riding a Ridable Turtle

Steps to Reproduce

1. Get ENet Super 1.40 (beta).

2. Go on a server (don't go on the pre-defined one, get a (preferably) local one, this probably also errors on sp).

3. Get a ridable turtle and fuel it.

4. Mount it.

5. Run "go forward" on it.

...

Expected behavior: The turtle would go forward with me

Actual behavior: It kicked me with "A fatal error has occured, this connection is terminated"

Stacktrace (if applicable): --

Version affected: PP1: v1.12.2-1.1-release-1 Forge: 14.23.5.2854 CC: (cc-tweaked) 1.88.0

Additional Information

this is NOT a crash.

Mod is not on curseforge thru the links on the readme
link: https://www.curseforge.com/minecraft/mc-mods/peripheralsplusone
was it moved?

Description

When I right click the Bee Analyzer, the game crashes.

Steps to Reproduce

1. Right click the Bee Analyzer

Expected behavior:
Bee Analyzer GUI opens
Actual behavior:
Game crashes with an NPE

Stacktrace (if applicable):
https://paste.ubuntu.com/p/8W2Gv9fZGR/

Version affected:
PPO 1.12.2-1.2-build-T65
Forge 14.23.5.2770

Description

When Nanobots are enabled, they can be used to control another player's (real) PC. Currently, the only way to plug that hole is to disable Nano Bot Swarms entirely. Which is a shame, since they are a lot of fun to goof around with. :)

Steps to Reproduce

As a proof of concept, I managed to give myself op on a friend's server.

1. Infect an admin/op player with nano bots.
2. Wait for them to go afk
3. Execute keyPress commands to open chat for them and input op command.
   [EDIT] removed explicit code example to increase friction for malicious actors that may be looking at this issue. If you need explicit code, I can send it via DM on a platform of your choice.

Assuming the other player uses Windows 10, it's almost trivially easy to step out of the game, open a command line, and start doing bad things. I'll do a quick POC for this scenario later today, and will add more info on how it went.
[EDIT 2] I was indeed able to control my friend's Windows command line. I can provide you with the code I used if needed.

Version affected: [1.12.2-1.1-build-T58] Forge: 14.23.5.2847

Description

[Description of the issue]

Steps to Reproduce

1. [First step]
2. [Second step]

...

Expected behavior: [What was supposed to happen]

Actual behavior: [What actually happened]

Stacktrace (if applicable): [PASTEBIN or HASTEBIN link to the stacktrace. Do NOT copy and paste the log into the issue post itself.]
I have no idea how to reproduce this cause it happen to one of my players that they are unable to join it seem it's has something to do with this line that it's a null error somehow
https://github.com/rolandoislas/PeripheralsPlusOne/blob/master/src/main/java/com/austinv11/peripheralsplusplus/turtles/peripherals/PeripheralChunkLoader.java#L49
Here is the error spam before clients get kick off the server
https://pastebin.com/raw/EvUV2TfA
EDIT: also comment out that line and saw why it seem this item was in the ME system and it started it doing this https://gyazo.com/f7be53afdcc90748a2eeee59b6913a8a
Version affected: [The version of PeripheralsPlusOne (e.g. x.x.x-x.x.x-build-Tx) and Forge]
PeripheralsPlusOne: 1.12.2-1.2-build-T71
Forge: 4.23.5.2836

Additional Information

[Any other information that may be able to help me with the problem]

Description

Peripheral Container in Pocket Computer only shows one peripheral

Steps to Reproduce

Craft Pocket Computer with Peripheral Container
Craft result with wireless modem
Craft result with speaker

Call container.getContainedPeripherals() =>It only ever shows the modem

...

Expected behavior: It should list all peripherals

Actual behavior: It only lists the first peripheral

Version affected: PeripheralsPlusOne-1.12.2-1.1-build-T58 and forge-14.23.5.2784

Description

I doubt this is informative enough to be solvable, but I am hoping someone might be able to provide insight. I am trying to add PPO to SevTech 3.2.1 (1.12.2), but am receiving the linked error with AE2.

Steps to Reproduce

1. Run SevTech 3.2.1 clean. (an unreasonable hassle for sure, hopefully you can spot the problem without it)
2. Add PeripheralsPlusOne
3. Profit.

...

Expected behavior: The modpack should handle PPO and not return this supposedly unrelated issue.

Actual behavior: SevTech crashes giving an error referencing Applied Energistics 2 and Botania (Yea, I don't know either. Not in the pack).

Stacktrace (if applicable): https://pastebin.com/UyZUHike

Version affected: Using PeripheralsPlusOne-1.12.2-1.1-build-T51 and forge 14.23.5.2854

Additional Information

If this has too many moving parts for a diagnosis I totally understand. Thanks for taking a look!
Good luck on getting curseforge's blessing once again y'all :)

MC: 1.12.2
Forge: 14.23.4.2705
CC: 1.80pr1
PPO: 1.12.2-1.1-build-T58

Description

• Thristy turtle doesn't suck.

Steps to Reproduce

1. Place turtle above of water source.
2. Call function turtle.suckDown()

Description

• turtle.drain() returns error (attempt to call nil).

Steps to Reproduce

1. Place a bucket of water in slot 1
2. Call function turtle.drain()

Description

Hey, using this mod with the forked version (CC:Tweaked) leads to little errors (Dynmount does not work)

Steps to Reproduce

• Install CC:Tweaked (1.8.pr1.5)
• Install PeripheralPlusOne (latest)

Expected behavior: Able to use dyn command within the console

Actual behavior: Dyn-Command is not registered and (i dont know if there is a reliation to this issue) sometimes computers cannot start anymore (but not tested without PeripheralPlusOne, maybe an issue with CC:Tweaked version)

Stacktrace (if applicable):
https://pastebin.com/2EPc4Nai

Version affected:
PeripheralsPlusOne-1.12.2-1.1-build-T58.jar
Forge 14.23.2.2627