rockefellerarchivecenter / as_export Goto Github PK

Once we launch DIMES-TNG, we don't need PDFs any more. This functionality should be removed from the script, along with supporting dependencies.

see https://www.dulwich.io

See http://toolbelt.readthedocs.org/en/latest/downloadutils.html

id() is reserved in Python for the identity function; see http://stackoverflow.com/questions/77552/id-is-a-bad-variable-name-in-python

from @thatandromeda and @pobocks

add destinations, other sections

thanks @marktriggs

The tree.walk method uses the deprecated tree endpoint. The application should be future-proofed by using the utils.walk_tree method instead.

Traceback (most recent call last):
  File "/home/harnold/asExportIncremental.py", line 391, in <module>
    logout()
  File "/home/harnold/asExportIncremental.py", line 88, in logout
    requests.post('{baseURL}/logout'.format(**dictionary), headers=headers)
NameError: global name 'headers' is not defined

Suspect the user is never logging into AS; hence they don't need to log out.

In alignments with efforts to reduce harmful and oppressive language in all aspects of the RAC's work, the default branch on this repository should be renamed from master to base.

1. Move to a new default branch and push:

git branch -m master base
git push -u origin base

2. Change default branch in GitHub.
3. Update any CI integrations (Travis CI/GitHub Actions) which rely on this branch.

Local clones can update refs as follows:

$ git checkout master
$ git branch -m master base
$ git fetch
$ git branch --unset-upstream
$ git branch -u origin/base
$ git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/base

from @thatandromeda
Or pass the variable from parent function?

from @thatandromeda

This application has no unit tests. Add them!

from @thatandromeda

e.g. either as JSON or using ConfigParser syntax

Currently, files are saved to a subdirectory with an identifier name. This was done because that's the structure XTF expects. However, now that we are no longer indexing things in XTF we don't need those intermediate directories anymore. Let's get rid of them to simplify things.

The similarity of naming across methods like handleResource(), handleDigitalObject(), etc. is a little confusing; they're important differences. Maybe name them by their intended result?

Log level is currently set to warning, even though info would be more appropriate, to avoid the multiple New HTTP Request lines logged by request module.

See http://www.python-requests.org/en/latest/user/advanced/#session-objects