robwise / drexel_msis_planner Goto Github PK

Decorators are not currently covered by tests.

Add course prerequisites, such as completing a designated prior course with a grade above a certain threshold. Example from TMS. Also note that prerequisites is one word and does not actually need a hyphen.

this will probably need to go in an "actions" dropdown that will eventually include "move" and possibly other actions

In general, columns in the schema that represent associations should have an index for performance, but some associations currently do not. It may be helpful to employ a gem that assists with finding association columns that are not indexed.

Also, while not required, it could potentially prevent strange behaviors to explicitly define foreign keys as such in the migrations files (this is different than the foreign_key: option in ActiveModel association methods).

The back button is in a weird place and there's no info about where you are.

https://codeclimate.com/github/robwise/drexel_msis_planner/ButtonsHelper

Website still needs a footer. Should probably include:

• Copyright
• GitHub link
• Twitter link
• Super-short description

The Plan model will need to report whether the courses in the plan violate prerequisite and corequisite requirements as well as over-enrollment (> 3 courses) and under-enrollment (0 courses) in active quarters.

Don't forget to address what it looks like if the user has no taken courses yet!

https://codeclimate.com/github/robwise/drexel_msis_planner/PlanStatisticsService

Currently, the functionality of the PlanStatisticsService is duplicated (in a less-optimized way) by the "Degree Status" page's stats section. The functionality should be extracted from PlanStatisticsService and then utilized by the "Degree Status" page.

For example, 201435 is actually the spring of 2015, not spring of 2014. This obviously makes the plan view very confusing.

https://codeclimate.com/github/robwise/drexel_msis_planner/User

• TakenCourses should display the earned grade.
• The "Degree Status" page should show a GPA

Similar to prerequisites, corequisites are a slightly looser requirement in that they allow for taking the requisite course concurrently (meaning the same quarter) with the requiring course.

https://codeclimate.com/github/robwise/drexel_msis_planner/TMSScraperService

Have production environment use SSL site-wide.

There is a lot of duplicate code between these two specs, largely due to the fact that PlanStatistics is a subclass of UsersDegreeStatisticsSpec. However, certain methods are overridden and have different behavior, so that will need to be taken into account.

I read this blog post about Heroku advising switching to Puma due to Unicorn's poor performance with slower clients.

https://codeclimate.com/github/robwise/drexel_msis_planner/Quarter

Send data to SegmentIO for integration with GA.

It would be nice to implement semantic URLs for resources like User, Plan, and Course.

The default Bootstrap styles have never been replaced, so the colors and typography are in bad need of some customizing.