Comments (3)
gnardin
commented on July 24, 2024
The main reason is that the Command's URN is used to recreate the Command object whenever it is received in the other edge of the protobuf communication. We can analyze the changes necessary to allow the Command object recreation using the ID rather than the String.
However, I recommend avoid embedding an enum for Commands in the protobuf to keep the communication isolated from the possible actions agents and the simulator can exchange. If we link them together, every time we changes the commands we will also need to change the protocol specification increasing the possibility of failure or mismatch versioning.
from rcrs-server.
modaresimr
commented on July 24, 2024
I have worked on that.
I think it makes the communication more consistent and also space efficient.
in v4 branch i provide such things
we will talk in the next meeting
…On Tue, 14 Sep 2021, 20:01 Luis Gustavo Nardin, ***@***.***> wrote:
The main reason is that the Command's URN is used to recreate the Command
object whenever it is received in the other edge of the protobuf
communication. We can analyze the changes necessary to allow the Command
object recreation using the ID rather than the String.
However, I recommend avoid embedding an enum for Commands in the protobuf
to keep the communication isolated from the possible actions agents and the
simulator can exchange. If we link them together, every time we changes the
commands we will also need to change the protocol specification increasing
the possibility of failure or mismatch versioning.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIO4RWEPC3CGRF6X4BZBW3UB6EXHANCNFSM5DXRI7RQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
from rcrs-server.
gnardin
commented on July 24, 2024
I see the changes made in the v4 branch. My opinion is that they include one more place to change every time we change any entity, property, or command in the simulator. The maintenance becomes more costly and the version control more challenging.
We can discuss these changes in the next meeting.
from rcrs-server.
Related Issues (20)
- Error launching `scenarioEditor` using Gradle HOT 6
- The bed continues occupied HOT 5
- ProtoBuf branch is not compatibile with the logs of traditional version HOT 2
- in ProtoBuf branch string urn is used for command but for others urnid is used HOT 1
- ProtoBuf not completely implimented HOT 2
- Merge enum and enum_v1 HOT 3
- organisation of folders HOT 3
- Feature request: using docker and build the docker into docker-hub HOT 3
- Feature request: WebApi to control the server HOT 1
- Migrate to Log4j2
- LogViewer cannot read rescue.log.xz. HOT 5
- Compatibility of log files on the new server with the previous server HOT 12
- Problems when trying to start the server HOT 8
- map change problem HOT 1
- Agents refuse to connect to server HOT 13
- Request for Modification Regarding Map Score Calculation Method HOT 1
- Is Gradle Required in Pre-installation for rcrs-server? HOT 2
- Question about 'merge nodes' functionality in rcrs-server's gml-editor. HOT 2
- Run server without any UI elements HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rcrs-server.