Code Monkey home page Code Monkey logo

Comments (2)

SRSaunders avatar SRSaunders commented on August 15, 2024 1

In DeviceManager_VK.cpp, would you try replacing the following code:

if( surfaceCaps.minImageExtent.width > requestedExtent.width ||
	surfaceCaps.minImageExtent.height > requestedExtent.height ||
	surfaceCaps.maxImageExtent.width < requestedExtent.width ||
	surfaceCaps.maxImageExtent.height < requestedExtent.height )
{
	errorStream << std::endl << "  - cannot support the requested swap chain size:";
	errorStream << " requested " << requestedExtent.width << "x" << requestedExtent.height << ", ";
	errorStream << " available " << surfaceCaps.minImageExtent.width << "x" << surfaceCaps.minImageExtent.height;
	errorStream << " - " << surfaceCaps.maxImageExtent.width << "x" << surfaceCaps.maxImageExtent.height;
	deviceIsGood = false;
}

with:

m_DeviceParams.backBufferWidth = std::clamp( m_DeviceParams.backBufferWidth, surfaceCaps.minImageExtent.width, surfaceCaps.maxImageExtent.width );
m_DeviceParams.backBufferHeight = std::clamp( m_DeviceParams.backBufferHeight, surfaceCaps.minImageExtent.height, surfaceCaps.maxImageExtent.height );

and let me know the result. There may be one more issue to solve regarding the initial SDL window size, but I would like to know the answer regarding the swapchain backbuffer sizes first. This might finally be the clue I was looking for regarding #740. Thx.

UPDATE: The idea was correct but in the wrong place, and the SDL window size does need adjustment to match the modified swap chain extent. I will post a PR that addresses this (and hopefully #740 as well). Don't bother testing with the above change until I post the PR. Thanks.

from rbdoom-3-bfg.

SRSaunders avatar SRSaunders commented on August 15, 2024

Hi @Oreolek, the fix for this is now merged into the head stream. If it solves your problem, would you please close this issue? Thx.

from rbdoom-3-bfg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.