robbesneyders / modular2recycler Goto Github PK

Hello, nice library and thank you for Open Sourcing it.

The following lines are duplicated because of some reason or just by mistake https://github.com/RobbeSneyders/UndoRecycler/blob/master/library/src/main/java/com/cuttingedge/undorecycler/UndoAdapter.java#L246 ?

The AdapterModule class passes a reference to this to an external class in its constructor. Seems like this could potentially create a leak, no?

To increase the library engage you should add a sample usage module to your project

gem install dryrun
dryrun https://github.com/RobbeSneyders/UndoRecycler

I was trying to run this and it didn't work, I was surprised to see that you had no sample since you have a beautiful gif of a "sample" :)

Are you planning to implement such feature as sticky headers (like in https://github.com/edubarr/header-decor . Looks like less or more compatible because of interfaces and decorations)? One AdapterModule can contain 2 ModularItem, 1 for common item and 1 for header and it will be cool to have some opportunity to link them and stick header

Hey,

Here are the steps to reproduce not seeing a list of items:

• Show a list of items like you would normally
• Change to portrait/ landscape (list will still be shown)
• Navigate to other activity
• Go back to previous activity (list is now gone)

Unfortunately I have no idea what goes wrong. I rewrote the code to use a normal adapter and now it works but I was hoping to use yours :)

Documentation from dispatchUpdatesTo:

DiffResult result = DiffUtil.calculateDiff(new MyCallback(oldList, newList));
mAdapter.setData(newList);
result.dispatchUpdatesTo(mAdapter);```

Hello, I just stumbled across your library and the design pattern looks pretty solid. But I'm slightly sad because it's trying to solve multiple problems by including extensions such as drag-and-drop, etc. I think this is bad because the extensions are not the job of Modular2Recycler as well as because I'm restricted to using only those extensions. I'd strongly recommend splitting this library.