When I run tests locally, I get the following warning

Warning (test-aggregate_alignment_loanbook_exposure.R:41:1): (code run outside of `test_that()`)
Using an external vector in selections was deprecated in tidyselect 1.1.0.
ℹ Please use `all_of()` or `any_of()` instead.
  # Was:
  data %>% select(group_vars)

  # Now:
  data %>% select(all_of(group_vars))

See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>.
Backtrace:
     ▆
  1. ├─test_data_aggregate_alignment_loanbook_exposure_net %>% ... at test-aggregate_alignment_loanbook_exposure.R:41:1
  2. ├─pacta.multi.loanbook.analysis::aggregate_alignment_loanbook_exposure(...)
  3. │ └─... %>% ... at pacta.multi.loanbook.analysis/R/aggregate_alignment_loanbook_exposure.R:132:3
  4. ├─dplyr::arrange(...)
  5. ├─dplyr::relocate(...)
  6. └─dplyr:::relocate.data.frame(...)
  7.   └─dplyr:::eval_relocate(...)
  8.     └─tidyselect::eval_select(...)
  9.       └─tidyselect:::eval_select_impl(...)
 10.         ├─tidyselect:::with_subscript_errors(...)
 11.         │ └─rlang::try_fetch(...)
 12.         │   └─base::withCallingHandlers(...)
 13.         └─tidyselect:::vars_select_eval(...)
 14.           └─tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 15.             └─tidyselect:::eval_c(expr, data_mask, context_mask)
 16.               └─tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 17.                 └─tidyselect:::walk_data_tree(new, data_mask, context_mask)
 18.                   └─tidyselect:::eval_c(expr, data_mask, context_mask)
 19.                     └─tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 20.                       └─tidyselect:::walk_data_tree(new, data_mask, context_mask)
 21.                         └─tidyselect:::eval_sym(expr, data_mask, context_mask)

changing this:

to this:

    dplyr::relocate(
      dplyr::all_of(
        c(
          group_vars, "n_companies", "n_companies_aligned",
          "share_companies_aligned", "exposure_weighted_net_alignment"
        )
      )
    ) %>%

squelches the warning

relates to #33

previously we used the column group_id to identify one variable by which to analyze/aggregate loan books. This is not ideal for the following reasons:

• users will normally always prepare data by loan book, so it is safe to assume that it is always possible to attribute an identifier to each loan book
• when analyzing the financial system, there is rarely a situation where we do not care about the individual loan book view
• group_id does not follow the naming conventions that other id variables in P4B use. It is normally id_* not *_id
• We still want to be able to analyze/aggregate the data by other dimensions, which we do by passing column names to the new group_var argument (see linked issue). This means that clearer disambiguation of names would be helpful.

AB#10594

copies: RMI-PACTA/pacta.aggregate.loanbook.plots#100

Unexported objects imported by ':::' calls:
    ‘r2dii.plot:::abort_if_missing_names’
    ‘r2dii.plot:::abort_if_unknown_values’
    See the note in ?`:::` about the use of this operator.

we decided to add the relevant functions to this package rather than exporting them in r2dii.plot

relates to RMI-PACTA/pacta.multi.loanbook.plot#2

Plots und prep functions are migrated to dedicated package

copied from: RMI-PACTA/pacta.aggregate.loanbook.plots#95

To be decided:

The handling of bridge technologies has not turned out to make a significant difference. It was therefore not used in the ECB report and there is currently no plan of using it elsewhere.
In the spirit of keeping the metric simple, we may want to remove it.

AB#10163

function has been moved to pacta.multi.loanbook.plot. it is only being used on plots, so not needed here

see RMI-PACTA/pacta.multi.loanbook.plot#12

possibly not always dry, but every test clearly understandable without looking anywhere outside the test https://r-pkgs.org/testing-design.html#self-sufficient-tests

copies: RMI-PACTA/pacta.aggregate.loanbook.plots#48

calculate_company_tech_deviation() and calculate_company_aggregate_alignment_sda() both use the internal data activity_units by default. This should be passed to the functions explicitly to avoid R-CMD notes.

code_level is deprecated in sector classifications in RMI-PACTA/r2dii.data#352

use an alternative

fyi @jdhoffa

AB#10277

This seems to be what the default R CMD check bade (that usethis creates) is expected.

This is why the badge isn't rendering here:

(Alternatively can change the link to point to R.yml, but i'd prefer the former option as it aligns with what 99% of our other repos already do).

cc: @AlexAxthelm

Relates to RMI-PACTA/pacta.sit.rep#18

currently pacta.multi.loanbook.analysis functions calculate results only for loan_size_outstanding by default. We want to provide it for loan_size_credit_limit too by default, based on conversation with GH

AB#10683

I believe there was a general issue related to how we used pkgdown, is that correct? do we know how to fix it?

@jdhoffa @cjyetman

AB#10482

follow the structure set up in pacta.multi.loanbook.plot

fyi @AlexAxthelm

copies: RMI-PACTA/pacta.aggregate.loanbook.plots#102

copies: RMI-PACTA/pacta.aggregate.loanbook.plots#101

no visible binding for global variable for variables in fill_missing_direction()

• Add testthat infrastructure
• test calculate_company_tech_deviation() and underlying functions
• test calculate_company_aggregate_alignment_tms() and underlying functions
• test calculate_company_aggregate_alignment_sda() and underlying functions
• test aggregate_alignment_loanbook_exposure() and underlying functions
• test create_benchmark_loanbook() and underlying functions

copied from RMI-PACTA/pacta.aggregate.loanbook.plots#46

see ecf risk sup, on ADO https://dev.azure.com/RMI-PACTA/2DegreesInvesting/_workitems/edit/10322