Code Monkey home page Code Monkey logo

atsea's People

Contributors

rkoron007 avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar

atsea's Issues

PA Review: Shopping Cart

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds

PA Review: Search

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds

Sample State

Sample State

  • State shape is flat!
  • State's keys are camelCased
  • All keys within the values in the state are accessible in the schema (Ex: if you create a img_url key in the state, make sure your database also has a column that contains an img_url)
  • Correctly formatted
    • Sample state is rendered with 3 back ticks before and after. This will display the state as a code block instead of a giant line of text
    • Top level slices
      • entities
      • session
      • errors (here or in ui)
      • ui (if needed)
    • Should NOT have nested slices, aka comments inside of posts
      • Some info from other tables is ok, for instance:
        • the author username and imageurl for a post. basically any info that the user can't change
        • like count and a boolean on whether the user likes the post instead of a likes slice

Comments:

Component Hierarchy with Wireframes

Component Hierarchy

  • All routes listed in the routes wiki page is also listed in the component hierarchy
  • Each component, if necessary, has route, state, and other components it renders
  • Necessary components are wrapped in a container
  • Correctly formatted
    • Bullet point hierarchy
    • Component names are displayed with inline coding text (backticks)
  • Wireframes included
    • Every component listed in the component hierarchy wiki page has at least one wireframe
    • Every MVPs listed on the MVP wiki page has at least one wireframe
    • Every route listed on the route wiki page has at least one wireframe
    • Contains Containers
    • Contains Lists
    • Contains ListItems
    • Correctly formatted
      • Wireframe images display on the page
      • Every wireframe has a header title

Comments:

  • Make sure you have a Wireframes pg (you can use the same images in the component hierarchy and the other one)

  • Edit some of the wording so it is clearer. Ex: On the user show page, I would change ListingItemIndexContainer to ItemContainer. Within that ItemContainer, there will be a ItemIndex that will show a list of ItemIndexItems.

  • All labels listed on the bullet points should also be labeled on the wireframe.

Wireframes

Wireframes

  • Every component listed in the component hierarchy wiki page has at least one wireframe
  • Every MVPs listed on the MVP wiki page has at least one wireframe
  • Every route listed on the route wiki page has at least one wireframe
  • Contains Containers
  • Contains Lists
  • Contains ListItems
  • Correctly formatted
    • Wireframe images display on the page
    • Every wireframe has a header title

Note:

  • They have enough wireframes. Pretend you are using their site through the wireframes and try to make sure they have all of the functionality
  • They contain some way of designating components and it looks like all major components are accounted for (arrows, etc)
  • They have decent spacial awareness

Comments:

Wiki Home Page

Wiki Page Home

  • Is the first page you see upon entering the wiki
  • Contains a welcome message
  • Contains a link/placeholder for a link to the live page
  • All links in the right sidebar should contain each wiki page and link to the correct page
  • Correctly formatted
    • each wiki page is listed in bullet points
    • all links route the correct page

Comments:

PA Review: Item Reviews

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds

PA Review: Items

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Styling
  • Smooth, bug-free navigation
  • Adequate and appropriate seeds

Database Schema

Database Schema

  • Contains correct datatypes NOTE: Certain fields should change their data type to text instead of string

  • Contains appropriate constraints/details

    • primary key
    • not null
    • unique
      • NOTE1: Certain fields should be indexed, especially since one of your MVPs is having a search feature
      • NOTE2: Did you want an item to appear multiple times on the cart with a quantity of 1 each? If not, you may want to add a uniqueness constraint.
    • indexed
    • foreign key
  • Contains bullet points after the table that state which foreign keys will reference to which table, or references to the associations which will be made

  • Correctly formatted

    • schema is written in a table format
    • column names are bolded
    • columns names are lowercased and snaked_cased
    • the names of the column names should be placed in back_ticks

Comments:

I saw on your state that ratings can be floats. You may want to change the data type for rating.
Keep in mind the current state of the db schema allows one item to have one picture. I think this is totally fine now however, in the future if you want an item to have multiple pictures, you'll need an images table and an images_items join table.

Routes

Routes

  • Routes accurately reflect MVPs and Component Hierarchy
  • Covers the frontend functionality of the site through routes that match to the wireframes
  • Contains the following sections: HTML, API Endpoints(Backend), and Frontend Routes
  • Each route has a description
  • API Endpoint routes contains wildcard variables written in snake_case
  • Frontend routes contains wildcard variables written in camelCase
  • Routes does not contain [superfluous routes]
    (https://github.com/appacademy/curriculum/blob/master/rails/readings/routing-part-ii.md)
    • When deleting a comment from an item, you wont need the item's id, you just need to comment's id.
  • Have API routes that will allow the front end to get all info it needs and does not have unneeded routes:
    • probably doesn't need a GET likes api endpoint bc that info comes through the post show
  • Correctly formatted
    • Routes are displayed with inline coding text (backticks)
    • NOTE: Oh no! You are just missing one route that doesn't have the correct formatting!

Comments:

PA Review: User Authentication #1

  • Backend: DB, model, controller, views
  • Redux Loop: ajax, actions, reducer
  • Presentational Components
  • Demo User Added
  • Styling
  • Smooth, bug free navigation
  • Login errors clears when switching from login form to sign up form (and vice-versa)
  • Adequate and appropriate seeds

MVP List

MVP List

  • Should have 7 MVPs.
    • 3 of those are User Auth, Heroku, and Production README.
    • The other 4 are from the MVP List or they have clarified them with you
  • Contains a description sentence of the app
  • At least one CRUD feature, which states what CRUD operations are planned (creation, reading, updating, deletion)
  • Estimates how long it will take the code each MVP
  • Correctly formatted
    • MVPs are listed in an ordered list
    • Each MVP is broken down into bullet points

Comments:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.