Code Monkey home page Code Monkey logo

Comments (2)

wangrunji0408 avatar wangrunji0408 commented on July 19, 2024 2

The reason for the repeat is that as is eliminated at binder stage and doesn't exist in the plan. In egg-based planner, common expressions always share the same node. So I didn't introduce the as node in order not to make things complicated.

I think there are 2 possible solutions for this issue:

  1. Resolve common expressions from child nodes and assign temporary variables for them in EXPLAIN. The output would be like:
    Projection { exprs: [ $0 ] }
    └── Projection { exprs: [ + { lhs: v1, rhs: v1 } as $0 ] }
        ...
    
  2. Keep as variable information by introducing as node to the planner. However, this may break some optimization rules and lead to unknown behavior.

from risinglight.

caicancai avatar caicancai commented on July 19, 2024

The reason for the repeat is that as is eliminated at binder stage and doesn't exist in the plan. In egg-based planner, common expressions always share the same node. So I didn't introduce the as node in order not to make things complicated.

I think there are 2 possible solutions for this issue:

  1. Resolve common expressions from child nodes and assign temporary variables for them in EXPLAIN. The output would be like:
    Projection { exprs: [ $0 ] }
    └── Projection { exprs: [ + { lhs: v1, rhs: v1 } as $0 ] }
        ...
    
  2. Keep as variable information by introducing as node to the planner. However, this may break some optimization rules and lead to unknown behavior.

It looks like option 1 might be simpler

from risinglight.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.